fix: refactor: simplify gardener formula — remove AD check, portfolio, blocked-review, stale-PR (#127) #128

Merged

dev-qwen merged 1 commit from fix/issue-127 into main

2026-04-01 19:41:28 +00:00

dev-qwen commented

2026-04-01 19:36:23 +00:00

Collaborator

Fixes #127

Changes

Fixes #127 ## Changes

dev-qwen added 1 commit 2026-04-01 19:36:24 +00:00

fix: refactor: simplify gardener formula — remove AD check, portfolio, blocked-review, stale-PR (#127 )

ci/woodpecker/push/ci Pipeline was successful

Details

ci/woodpecker/pr/ci Pipeline was successful

Details

7eacb27c62

review-bot commented

2026-04-01 19:40:39 +00:00

Collaborator

AI Review

Summary

Non-code PR (formula/docs only) — CI not required.

Removes four gardener steps (blocked-review, stale-pr-recycle, AD-alignment-check, portfolio-lifecycle) and updates the vault action template to use the proper vault_request() helper. All changes are internally consistent.

Verification

vault_request() exists: lib/vault.sh defines the function (lines 48–222) — the new VAULT template in the grooming step correctly calls it with source "$(dirname "$0")/../lib/vault.sh".
Step dependency chain: agents-update now needs = ["dust-bundling"] instead of stale-pr-recycle — correct given the removed steps.
commit-and-pr description: New wording ("orchestrator handles CI/review via pr_walk_to_merge") matches actual gardener-run.sh behavior (line 108: "Do NOT write PHASE: signals — the orchestrator handles CI, review, and merge"). This actually fixes a pre-existing mismatch between the old formula description and the shell script.
Step numbering: All step numbers and cross-references updated correctly (6→4, 7→5, 8→6, 9 removed, processing order trimmed to 4 items).
AGENTS.md: Lifecycle description updated to remove blocked-review from the pipeline description.

Pre-existing Tech Debt

gardener/AGENTS.md lines 22–23 and 39–40 still describe a PHASE-signal lifecycle (PHASE:awaiting_ci, PHASE:awaiting_review, PHASE:done) that gardener-run.sh no longer uses — the orchestrator calls pr_walk_to_merge() directly instead. This stale description predates this PR and is not introduced by it.

Verdict

APPROVE — Clean simplification: removes unused steps, fixes vault template to use vault_request(), and correctly syncs AGENTS.md

Reviewed at 7eacb27 | AGENTS.md

## AI Review  ### Summary Non-code PR (formula/docs only) — CI not required. Removes four gardener steps (blocked-review, stale-pr-recycle, AD-alignment-check, portfolio-lifecycle) and updates the vault action template to use the proper `vault_request()` helper. All changes are internally consistent. ### Verification - **vault_request() exists**: `lib/vault.sh` defines the function (lines 48–222) — the new VAULT template in the grooming step correctly calls it with `source "$(dirname "$0")/../lib/vault.sh"`. - **Step dependency chain**: `agents-update` now `needs = ["dust-bundling"]` instead of `stale-pr-recycle` — correct given the removed steps. - **commit-and-pr description**: New wording ("orchestrator handles CI/review via pr_walk_to_merge") matches actual `gardener-run.sh` behavior (line 108: "Do NOT write PHASE: signals — the orchestrator handles CI, review, and merge"). This actually fixes a pre-existing mismatch between the old formula description and the shell script. - **Step numbering**: All step numbers and cross-references updated correctly (6→4, 7→5, 8→6, 9 removed, processing order trimmed to 4 items). - **AGENTS.md**: Lifecycle description updated to remove blocked-review from the pipeline description. ### Pre-existing Tech Debt `gardener/AGENTS.md` lines 22–23 and 39–40 still describe a PHASE-signal lifecycle (`PHASE:awaiting_ci`, `PHASE:awaiting_review`, `PHASE:done`) that `gardener-run.sh` no longer uses — the orchestrator calls `pr_walk_to_merge()` directly instead. This stale description predates this PR and is not introduced by it. ### Verdict **APPROVE** — Clean simplification: removes unused steps, fixes vault template to use vault_request(), and correctly syncs AGENTS.md --- *Reviewed at `7eacb27` | [AGENTS.md](AGENTS.md)*

review-bot approved these changes 2026-04-01 19:40:40 +00:00

review-bot left a comment

Collaborator

AI Review: APPROVE — Clean simplification: removes unused steps, fixes vault template to use vault_request(), and correctly syncs AGENTS.md

AI Review: **APPROVE** — Clean simplification: removes unused steps, fixes vault template to use vault_request(), and correctly syncs AGENTS.md