fix: install shellcheck in agents Dockerfile #48

Closed
opened 2026-03-29 07:23:09 +00:00 by dev-bot · 0 comments
Collaborator

Problem

The CI pipeline runs shellcheck but the agents container does not have shellcheck installed. When the dev-agent gets a CI failure from shellcheck, it tries to reproduce locally, can't find shellcheck, and wastes all its CI fix attempts trying to download and install it from GitHub.

Fix

Add shellcheck to docker/agents/Dockerfile:

RUN apt-get update && apt-get install -y --no-install-recommends \
    bash curl git jq tmux cron python3 python3-pip openssh-client ca-certificates age shellcheck \
    ...

Debian bookworm has shellcheck in its repos (apt install shellcheck).

Why it matters

Without shellcheck, the model:

  1. Gets CI failure: "shellcheck found error on line X"
  2. Tries shellcheck bin/disinto locally → command not found
  3. Tries to curl shellcheck binary from GitHub → may fail (network, permissions)
  4. Wastes all 3 CI fix attempts on tool installation instead of fixing the actual code

With shellcheck installed, it can reproduce and fix in one attempt.

Affected files

  • docker/agents/Dockerfile
## Problem The CI pipeline runs shellcheck but the agents container does not have shellcheck installed. When the dev-agent gets a CI failure from shellcheck, it tries to reproduce locally, can't find shellcheck, and wastes all its CI fix attempts trying to download and install it from GitHub. ## Fix Add shellcheck to `docker/agents/Dockerfile`: ```dockerfile RUN apt-get update && apt-get install -y --no-install-recommends \ bash curl git jq tmux cron python3 python3-pip openssh-client ca-certificates age shellcheck \ ... ``` Debian bookworm has `shellcheck` in its repos (`apt install shellcheck`). ## Why it matters Without shellcheck, the model: 1. Gets CI failure: "shellcheck found error on line X" 2. Tries `shellcheck bin/disinto` locally → command not found 3. Tries to `curl` shellcheck binary from GitHub → may fail (network, permissions) 4. Wastes all 3 CI fix attempts on tool installation instead of fixing the actual code With shellcheck installed, it can reproduce and fix in one attempt. ## Affected files - `docker/agents/Dockerfile`
dev-bot added the
backlog
label 2026-03-29 07:23:09 +00:00
disinto-admin added the
priority
label 2026-03-29 08:22:44 +00:00
dev-qwen self-assigned this 2026-03-29 08:37:21 +00:00
dev-qwen added
in-progress
and removed
backlog
labels 2026-03-29 08:37:21 +00:00
dev-qwen removed their assignment 2026-03-29 08:44:18 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: johba/disinto#48
No description provided.