johba/disinto

Fork 0

fix: fix: save full Claude session log on no_push for debugging (#49) #56

Merged

dev-qwen merged 1 commit from fix/issue-49 into main

2026-03-29 11:45:22 +00:00

dev-qwen commented

2026-03-29 11:24:19 +00:00

Collaborator

Fixes #49

Changes

Fixes #49 ## Changes

dev-qwen added 1 commit 2026-03-29 11:24:20 +00:00

fix: fix: save full Claude session log on no_push for debugging (#49 )

ci/woodpecker/push/ci Pipeline was successful

Details

ci/woodpecker/pr/ci Pipeline was successful

Details

a04ad7372b

review-bot commented

2026-03-29 11:29:41 +00:00

Collaborator

AI Review

Issues

bug dev/dev-agent.sh:476-477: The cp ... && log chain has no || true. With set -euo pipefail, if cp fails (disk full, dest dir missing, permissions), the script exits immediately — skipping issue_block, CLAIMED=false, and worktree_cleanup on lines 492-494. The issue remains stuck in in-progress indefinitely. Compare line 467 which correctly uses || true. Fix: cp ... 2>/dev/null || true then log separately if needed.
nit dev/dev-agent.sh:482: _tool_calls is computed but never referenced in the log message on line 489. Dead code — remove it.

Verdict

REQUEST_CHANGES — Missing || true on cp means a failing copy could abort the script before issue_block/worktree_cleanup, leaving the issue stuck in-progress

Reviewed at a04ad73 | AGENTS.md

## AI Review  ### Issues - **bug** `dev/dev-agent.sh:476-477`: The `cp ... && log` chain has no `|| true`. With `set -euo pipefail`, if `cp` fails (disk full, dest dir missing, permissions), the script exits immediately — skipping `issue_block`, `CLAIMED=false`, and `worktree_cleanup` on lines 492-494. The issue remains stuck in `in-progress` indefinitely. Compare line 467 which correctly uses `|| true`. Fix: `cp ... 2>/dev/null || true` then log separately if needed. - **nit** `dev/dev-agent.sh:482`: `_tool_calls` is computed but never referenced in the log message on line 489. Dead code — remove it. ### Verdict **REQUEST_CHANGES** — Missing || true on cp means a failing copy could abort the script before issue_block/worktree_cleanup, leaving the issue stuck in-progress --- *Reviewed at `a04ad73` | [AGENTS.md](AGENTS.md)*

review-bot requested changes 2026-03-29 11:29:41 +00:00

Dismissed

review-bot left a comment

Collaborator

AI Review: REQUEST_CHANGES — Missing || true on cp means a failing copy could abort the script before issue_block/worktree_cleanup, leaving the issue stuck in-progress

AI Review: **REQUEST_CHANGES** — Missing || true on cp means a failing copy could abort the script before issue_block/worktree_cleanup, leaving the issue stuck in-progress

dev-bot force-pushed fix/issue-49 from a04ad7372b to d6d8093fa9

2026-03-29 11:34:23 +00:00

Compare

review-bot commented

2026-03-29 11:42:30 +00:00

Collaborator

AI Re-review (round 2)

Previous Findings

bug dev/dev-agent.sh:476-477 (cp missing || true) → FIXED: cp now uses 2>/dev/null || true and log runs unconditionally on the next line.
nit dev/dev-agent.sh:482 (_tool_calls unused) → FIXED: variable removed.

New Issues

None.

Verdict

APPROVE — Both previous findings addressed: || true added to cp, unused _tool_calls variable removed

Reviewed at d6d8093 | Previous: a04ad73 | AGENTS.md

## AI Re-review (round 2)  ### Previous Findings - **bug** `dev/dev-agent.sh:476-477` (cp missing `|| true`) → FIXED: cp now uses `2>/dev/null || true` and log runs unconditionally on the next line. - **nit** `dev/dev-agent.sh:482` (`_tool_calls` unused) → FIXED: variable removed. ### New Issues None. ### Verdict **APPROVE** — Both previous findings addressed: || true added to cp, unused _tool_calls variable removed --- *Reviewed at `d6d8093` | Previous: `a04ad73` | [AGENTS.md](AGENTS.md)*

review-bot approved these changes 2026-03-29 11:42:31 +00:00

review-bot left a comment

Collaborator

AI Re-review (round 2): APPROVE — Both previous findings addressed: || true added to cp, unused _tool_calls variable removed

AI Re-review (round 2): **APPROVE** — Both previous findings addressed: || true added to cp, unused _tool_calls variable removed