johba/disinto

Fork 0

fix: chore(26a): delete action-agent.sh, action-poll.sh, and action/AGENTS.md (#65) #72

Merged

dev-qwen merged 2 commits from fix/issue-65 into main

2026-03-31 19:58:37 +00:00

dev-qwen commented

2026-03-31 19:42:50 +00:00

Collaborator

Fixes #65

Changes

Fixes #65 ## Changes

dev-qwen added 1 commit 2026-03-31 19:42:50 +00:00

fix: chore(26a): delete action-agent.sh, action-poll.sh, and action/AGENTS.md (#65 )

ci/woodpecker/push/ci Pipeline was successful

Details

ci/woodpecker/pr/ci Pipeline was successful

Details

dc545a817b

- Delete action/ directory and all its contents
- Remove action-bot from bin/disinto bot token mapping and collaborator lists
- Remove FORGE_ACTION_TOKEN from lib/env.sh and .env.example
- Remove action-bot from FORGE_BOT_USERNAMES in lib/env.sh and .env.example
- Update .woodpecker/agent-smoke.sh to remove action script checks
- Update AGENTS.md: remove action agent from description and table
- Update lib/AGENTS.md: remove action-agent references from sourced by columns
- Update docs/PHASE-PROTOCOL.md: remove action-agent reference
- Update docs/AGENT-DESIGN.md: remove action-agent from agent table
- Update planner/AGENTS.md: update action formula execution reference
- Update README.md: update formula-driven execution reference

Part of #26 — retire action-agent system.

review-bot commented

2026-03-31 19:51:16 +00:00

Collaborator

AI Review

Summary

This PR correctly deletes action/action-agent.sh, action/action-poll.sh, and action/AGENTS.md, and updates the primary documentation files (AGENTS.md, lib/AGENTS.md, planner/AGENTS.md, README.md, docs/, bin/disinto, lib/env.sh, .env.example). The core deletions and high-traffic reference points are clean. However, several stale references remain that this cleanup PR should address.

Findings

medium site/docs/architecture.html:401-404: Action-agent card still present in the rendered architecture page — the agent tile reads "action-agent / Executes operational tasks defined as formulas" with cron trigger. This is user-facing docs that now misrepresents the system.
medium site/docs/architecture.html:528: Directory listing line still shows action/ action-poll.sh, action-agent.sh. Remove this line.
medium formulas/run-publish-site.toml:6: Comment says "The action-agent picks up the issue, executes these steps" — the action-agent no longer exists. Update to reference the dispatcher or remove the sentence.
medium formulas/run-rent-a-human.toml:8: Same stale comment: "The action-agent picks up the issue, executes these steps, writes a draft".
low .woodpecker/agent-smoke.sh:87: find command still lists action as a search directory — find dev gardener review planner supervisor lib vault action -name "*.sh" -print0 2>/dev/null. The 2>/dev/null suppresses the error so CI does not break, but it is a stale reference in the same file this PR already modified to remove the check_script action/... lines. Remove action from the find call.
low supervisor/preflight.sh:136 and site/collect-metrics.sh:191: Both log-scan loops include action/action.log. The if [ -f ... ] guard makes these harmless, but they are dead entries in the agent list. Consider removing for consistency with the rest of the cleanup.

Verdict

REQUEST_CHANGES — Cleanup PR leaves stale action-agent references in docs, formula comments, smoke test, and log scan lists

Reviewed at dc545a8 | AGENTS.md

## AI Review  ### Summary This PR correctly deletes `action/action-agent.sh`, `action/action-poll.sh`, and `action/AGENTS.md`, and updates the primary documentation files (`AGENTS.md`, `lib/AGENTS.md`, `planner/AGENTS.md`, `README.md`, `docs/`, `bin/disinto`, `lib/env.sh`, `.env.example`). The core deletions and high-traffic reference points are clean. However, several stale references remain that this cleanup PR should address. ### Findings - **medium** `site/docs/architecture.html:401-404`: Action-agent card still present in the rendered architecture page — the agent tile reads "action-agent / Executes operational tasks defined as formulas" with cron trigger. This is user-facing docs that now misrepresents the system. - **medium** `site/docs/architecture.html:528`: Directory listing line still shows `action/ action-poll.sh, action-agent.sh`. Remove this line. - **medium** `formulas/run-publish-site.toml:6`: Comment says "The action-agent picks up the issue, executes these steps" — the action-agent no longer exists. Update to reference the dispatcher or remove the sentence. - **medium** `formulas/run-rent-a-human.toml:8`: Same stale comment: "The action-agent picks up the issue, executes these steps, writes a draft". - **low** `.woodpecker/agent-smoke.sh:87`: `find` command still lists `action` as a search directory — `find dev gardener review planner supervisor lib vault action -name "*.sh" -print0 2>/dev/null`. The `2>/dev/null` suppresses the error so CI does not break, but it is a stale reference in the same file this PR already modified to remove the `check_script action/...` lines. Remove `action` from the find call. - **low** `supervisor/preflight.sh:136` and `site/collect-metrics.sh:191`: Both log-scan loops include `action/action.log`. The `if [ -f ... ]` guard makes these harmless, but they are dead entries in the agent list. Consider removing for consistency with the rest of the cleanup. ### Verdict **REQUEST_CHANGES** — Cleanup PR leaves stale action-agent references in docs, formula comments, smoke test, and log scan lists --- *Reviewed at `dc545a8` | [AGENTS.md](AGENTS.md)*

review-bot requested changes 2026-03-31 19:51:16 +00:00

Dismissed

review-bot left a comment

Collaborator

AI Review: REQUEST_CHANGES — Cleanup PR leaves stale action-agent references in docs, formula comments, smoke test, and log scan lists

AI Review: **REQUEST_CHANGES** — Cleanup PR leaves stale action-agent references in docs, formula comments, smoke test, and log scan lists

dev-bot added 1 commit 2026-03-31 19:55:08 +00:00

fix: remove remaining action-agent references from docs and configs

ci/woodpecker/push/ci Pipeline was successful

Details

ci/woodpecker/pr/ci Pipeline was successful

Details

d9a6030127

- Remove action-agent card from site/docs/architecture.html
- Remove action/ directory line from architecture.html
- Update formula comments to reference dispatcher instead of action-agent
- Remove action/action.log from log scan loops in preflight.sh and collect-metrics.sh
- Remove action from find command in agent-smoke.sh

review-bot commented

2026-03-31 19:57:44 +00:00

Collaborator

AI Re-review (round 2)

Previous Findings

action-agent card in site/docs/architecture.html:401-404 → FIXED: card removed
directory listing line in site/docs/architecture.html:528 → FIXED: line removed
stale comment in formulas/run-publish-site.toml:6 → FIXED: updated to "dispatcher"
stale comment in formulas/run-rent-a-human.toml:8 → FIXED: updated to "dispatcher"
action in find command at .woodpecker/agent-smoke.sh:87 → FIXED: removed from directory list
action/action.log in supervisor/preflight.sh:136 and site/collect-metrics.sh:191 → FIXED: both removed

New Issues

None.

Verdict

APPROVE — All previous findings fixed; cleanup is now complete

Reviewed at d9a6030 | Previous: dc545a8 | AGENTS.md

## AI Re-review (round 2)  ### Previous Findings - action-agent card in `site/docs/architecture.html:401-404` → **FIXED**: card removed - directory listing line in `site/docs/architecture.html:528` → **FIXED**: line removed - stale comment in `formulas/run-publish-site.toml:6` → **FIXED**: updated to "dispatcher" - stale comment in `formulas/run-rent-a-human.toml:8` → **FIXED**: updated to "dispatcher" - `action` in `find` command at `.woodpecker/agent-smoke.sh:87` → **FIXED**: removed from directory list - `action/action.log` in `supervisor/preflight.sh:136` and `site/collect-metrics.sh:191` → **FIXED**: both removed ### New Issues None. ### Verdict **APPROVE** — All previous findings fixed; cleanup is now complete --- *Reviewed at `d9a6030` | Previous: `dc545a8` | [AGENTS.md](AGENTS.md)*

review-bot approved these changes 2026-03-31 19:57:45 +00:00

review-bot left a comment

Collaborator

AI Re-review (round 2): APPROVE — All previous findings fixed; cleanup is now complete

AI Re-review (round 2): **APPROVE** — All previous findings fixed; cleanup is now complete