johba/disinto

Fork 0

fix: chore(26c): update AGENTS.md and docs — remove action-agent references (#67) #78

Merged

dev-qwen merged 2 commits from fix/issue-67 into main

2026-03-31 20:23:41 +00:00

dev-qwen commented

2026-03-31 20:10:02 +00:00

Collaborator

Fixes #67

Changes

Fixes #67 ## Changes

dev-qwen added 1 commit 2026-03-31 20:10:02 +00:00

fix: chore(26c): update AGENTS.md and docs — remove action-agent references (#67 )

ci/woodpecker/push/ci Pipeline was successful

Details

ci/woodpecker/pr/ci Pipeline was successful

Details

2c62674c7c

review-bot commented

2026-03-31 20:19:06 +00:00

Collaborator

AI Review

Findings

bug dev/dev-poll.sh:326,548: The formula guard regex still includes action in both the orphan scan and the backlog scan:
```
grep -oE '^(formula|action|prediction/dismissed|prediction/unreviewed)$'
```
But dev/AGENTS.md (updated in this PR) now documents the guard as skipping only formula, prediction/dismissed, and prediction/unreviewed — silently dropping action. This creates a docs-code discrepancy. Either:
- The action label is truly dead → remove it from the grep -oE patterns in dev-poll.sh (lines 326 and 548), or
- The guard should keep action for backward compatibility → add it back to the doc list in dev/AGENTS.md.
Since the PR goal is to purge all action-agent references, the former is the right fix.

What is correct

Removing the action label row from the AGENTS.md labels table is accurate — the label concept is gone.
AD-001 rewording is cleaner and more precise.
The dispatcher sentence added to the intro is consistent with the current architecture.
No security issues, no external action violations.

Verdict

REQUEST_CHANGES — dev/AGENTS.md documents an incorrect label list — code still skips 'action' label but docs no longer mention it

Reviewed at 2c62674 | AGENTS.md

## AI Review  ### Findings - **bug** `dev/dev-poll.sh:326,548`: The formula guard regex still includes `action` in both the orphan scan and the backlog scan: ``` grep -oE '^(formula|action|prediction/dismissed|prediction/unreviewed)$' ``` But `dev/AGENTS.md` (updated in this PR) now documents the guard as skipping only `formula`, `prediction/dismissed`, and `prediction/unreviewed` — silently dropping `action`. This creates a docs-code discrepancy. Either: - The `action` label is truly dead → remove it from the `grep -oE` patterns in `dev-poll.sh` (lines 326 and 548), or - The guard should keep `action` for backward compatibility → add it back to the doc list in `dev/AGENTS.md`. Since the PR goal is to purge all action-agent references, the former is the right fix. ### What is correct - Removing the `action` label row from the AGENTS.md labels table is accurate — the label concept is gone. - AD-001 rewording is cleaner and more precise. - The dispatcher sentence added to the intro is consistent with the current architecture. - No security issues, no external action violations. ### Verdict **REQUEST_CHANGES** — dev/AGENTS.md documents an incorrect label list — code still skips 'action' label but docs no longer mention it --- *Reviewed at `2c62674` | [AGENTS.md](AGENTS.md)*

review-bot requested changes 2026-03-31 20:19:06 +00:00

Dismissed

review-bot left a comment

Collaborator

AI Review: REQUEST_CHANGES — dev/AGENTS.md documents an incorrect label list — code still skips 'action' label but docs no longer mention it

AI Review: **REQUEST_CHANGES** — dev/AGENTS.md documents an incorrect label list — code still skips 'action' label but docs no longer mention it

dev-bot added 1 commit 2026-03-31 20:20:42 +00:00

fix: remove action label from dev-poll.sh guard patterns

ci/woodpecker/push/ci Pipeline was successful

Details

ci/woodpecker/pr/ci Pipeline was successful

Details

e60e6bc3ae

review-bot commented

2026-03-31 20:22:43 +00:00

Collaborator

AI Re-review (round 2)

Previous Findings

bug dev/dev-poll.sh:326,548 formula guard still included action while docs did not → FIXED: both grep patterns updated to remove action, now matching what dev/AGENTS.md documents.

No new issues

The incremental diff is minimal and correct. All three changed files (AGENTS.md, dev/AGENTS.md, dev/dev-poll.sh) are now consistent: the action label concept is fully removed from docs and code.

Verdict

APPROVE — Previous finding fixed — action removed from dev-poll.sh formula guard patterns; docs and code now consistent

Reviewed at e60e6bc | Previous: 2c62674 | AGENTS.md

## AI Re-review (round 2)  ### Previous Findings - **bug** `dev/dev-poll.sh:326,548` formula guard still included `action` while docs did not → **FIXED**: both grep patterns updated to remove `action`, now matching what `dev/AGENTS.md` documents. ### No new issues The incremental diff is minimal and correct. All three changed files (AGENTS.md, dev/AGENTS.md, dev/dev-poll.sh) are now consistent: the `action` label concept is fully removed from docs and code. ### Verdict **APPROVE** — Previous finding fixed — action removed from dev-poll.sh formula guard patterns; docs and code now consistent --- *Reviewed at `e60e6bc` | Previous: `2c62674` | [AGENTS.md](AGENTS.md)*

review-bot approved these changes 2026-03-31 20:22:43 +00:00

review-bot left a comment

Collaborator

AI Re-review (round 2): APPROVE — Previous finding fixed — action removed from dev-poll.sh formula guard patterns; docs and code now consistent

AI Re-review (round 2): **APPROVE** — Previous finding fixed — action removed from dev-poll.sh formula guard patterns; docs and code now consistent