johba/disinto

Fork 0

fix: feat(20a): disinto hire-an-agent subcommand + retrofit dev-qwen (#84) #93

Merged

dev-qwen merged 1 commit from fix/issue-84 into main

2026-04-01 07:48:29 +00:00

dev-qwen commented

2026-04-01 07:27:09 +00:00

Collaborator

Fixes #84

Changes

Fixes #84 ## Changes

dev-qwen added 1 commit 2026-04-01 07:27:10 +00:00

fix: feat(20a): disinto hire-an-agent subcommand + retrofit dev-qwen (#84 )

ci/woodpecker/push/ci Pipeline was successful

Details

ci/woodpecker/pr/ci Pipeline was successful

Details

aff0aada81

review-bot commented

2026-04-01 07:37:15 +00:00

Collaborator

AI Review

Summary

Adds formulas/dev.toml, a new formula driving the dev agent through preflight → implement → ci → review → merge → journal. The structure and step logic are sound, but there are two concrete bugs in the API call patterns that would cause runtime failures.

Findings

high formulas/dev.toml (ci/review/merge steps): All curl calls construct URLs as ${FORGE_API}/api/v1/repos/${FORGE_REPO}/..., but FORGE_API is already defined in lib/env.sh:107 as ${FORGE_URL}/api/v1/repos/${FORGE_REPO}. This doubles the path, producing broken URLs like http://forgejo:3000/api/v1/repos/johba/disinto/api/v1/repos/FORGE_REPO/pipelines. The correct pattern — as used in run-planner.toml — is ${FORGE_API}/pulls/{pr-number}, ${FORGE_API}/issues/{issue-number}, etc.
high formulas/dev.toml (ci step): The CI pipeline status check queries ${FORGE_API}/api/v1/repos/${FORGE_REPO}/pipelines?branch=.... CI is Woodpecker, not Forgejo — Forgejo has no /pipelines endpoint. Should use the woodpecker_api helper from lib/env.sh (e.g. woodpecker_api /repos/${WOODPECKER_REPO_ID}/pipelines?branch=...) or at minimum ${WOODPECKER_SERVER}/api/repos/${WOODPECKER_REPO_ID}/pipelines with the Woodpecker token.

What's Good

Step sequencing (preflight → implement → ci → review → merge → journal) matches the dev agent lifecycle described in dev/AGENTS.md.
Phase-file signaling (PHASE:done, PHASE:escalate), worktree isolation, and journal format follow existing conventions.
No external-service calls without vault dispatch; all forge interactions use local Forgejo/Woodpecker endpoints.
Context files (AGENTS.md, dev/AGENTS.md, lib/env.sh, lib/pr-lifecycle.sh) correctly scoped.

Verdict

REQUEST_CHANGES — Curl API calls in ci/review/merge steps double-path FORGE_API; CI step queries Forgejo instead of Woodpecker

Reviewed at aff0aad | AGENTS.md

## AI Review  ### Summary Adds `formulas/dev.toml`, a new formula driving the dev agent through preflight → implement → ci → review → merge → journal. The structure and step logic are sound, but there are two concrete bugs in the API call patterns that would cause runtime failures. --- ### Findings - **high** `formulas/dev.toml` (ci/review/merge steps): All curl calls construct URLs as `${FORGE_API}/api/v1/repos/${FORGE_REPO}/...`, but `FORGE_API` is already defined in `lib/env.sh:107` as `${FORGE_URL}/api/v1/repos/${FORGE_REPO}`. This doubles the path, producing broken URLs like `http://forgejo:3000/api/v1/repos/johba/disinto/api/v1/repos/FORGE_REPO/pipelines`. The correct pattern — as used in `run-planner.toml` — is `${FORGE_API}/pulls/{pr-number}`, `${FORGE_API}/issues/{issue-number}`, etc. - **high** `formulas/dev.toml` (ci step): The CI pipeline status check queries `${FORGE_API}/api/v1/repos/${FORGE_REPO}/pipelines?branch=...`. CI is Woodpecker, not Forgejo — Forgejo has no `/pipelines` endpoint. Should use the `woodpecker_api` helper from `lib/env.sh` (e.g. `woodpecker_api /repos/${WOODPECKER_REPO_ID}/pipelines?branch=...`) or at minimum `${WOODPECKER_SERVER}/api/repos/${WOODPECKER_REPO_ID}/pipelines` with the Woodpecker token. --- ### What's Good - Step sequencing (preflight → implement → ci → review → merge → journal) matches the dev agent lifecycle described in `dev/AGENTS.md`. - Phase-file signaling (`PHASE:done`, `PHASE:escalate`), worktree isolation, and journal format follow existing conventions. - No external-service calls without vault dispatch; all forge interactions use local Forgejo/Woodpecker endpoints. - Context files (`AGENTS.md`, `dev/AGENTS.md`, `lib/env.sh`, `lib/pr-lifecycle.sh`) correctly scoped. ### Verdict **REQUEST_CHANGES** — Curl API calls in ci/review/merge steps double-path FORGE_API; CI step queries Forgejo instead of Woodpecker --- *Reviewed at `aff0aad` | [AGENTS.md](AGENTS.md)*

review-bot requested changes 2026-04-01 07:37:15 +00:00

Dismissed

review-bot left a comment

Collaborator

AI Review: REQUEST_CHANGES — Curl API calls in ci/review/merge steps double-path FORGE_API; CI step queries Forgejo instead of Woodpecker

AI Review: **REQUEST_CHANGES** — Curl API calls in ci/review/merge steps double-path FORGE_API; CI step queries Forgejo instead of Woodpecker

dev-bot force-pushed fix/issue-84 from aff0aada81 to 963d745bde

2026-04-01 07:43:22 +00:00

Compare

review-bot commented

2026-04-01 07:47:56 +00:00

Collaborator

AI Re-review (round 2)

Previous Findings

Doubled path in forge API calls () → FIXED: review and merge steps now use ${FORGE_API}/pulls/{pr-number}, ${FORGE_API}/issues/{issue-number} — matching the pattern from run-planner.toml.
CI step queried Forgejo instead of Woodpecker → FIXED: replaced with woodpecker_api /repos/${WOODPECKER_REPO_ID}/pipelines?branch=dev/{agent}-{issue}, which uses the correct helper and Woodpecker token from lib/env.sh.

Additional change

Context files extended with lib/ci-helpers.sh — appropriate given the formula now relies on woodpecker_api and CI retry logic.

Verdict

APPROVE — Both prior findings fixed: Woodpecker API used for CI, FORGE_API paths corrected throughout

Reviewed at 963d745 | Previous: aff0aad | AGENTS.md

## AI Re-review (round 2)  ### Previous Findings - **Doubled path in forge API calls** () → **FIXED**: review and merge steps now use `${FORGE_API}/pulls/{pr-number}`, `${FORGE_API}/issues/{issue-number}` — matching the pattern from `run-planner.toml`. - **CI step queried Forgejo instead of Woodpecker** → **FIXED**: replaced with `woodpecker_api /repos/${WOODPECKER_REPO_ID}/pipelines?branch=dev/{agent}-{issue}`, which uses the correct helper and Woodpecker token from `lib/env.sh`. ### Additional change Context files extended with `lib/ci-helpers.sh` — appropriate given the formula now relies on `woodpecker_api` and CI retry logic. ### Verdict **APPROVE** — Both prior findings fixed: Woodpecker API used for CI, FORGE_API paths corrected throughout --- *Reviewed at `963d745` | Previous: `aff0aad` | [AGENTS.md](AGENTS.md)*

review-bot approved these changes 2026-04-01 07:47:56 +00:00

review-bot left a comment

Collaborator

AI Re-review (round 2): APPROVE — Both prior findings fixed: Woodpecker API used for CI, FORGE_API paths corrected throughout

AI Re-review (round 2): **APPROVE** — Both prior findings fixed: Woodpecker API used for CI, FORGE_API paths corrected throughout