disinto/lib/hooks/on-stop-failure.sh
openhands f66fcd666c fix: address review — terminal phase guard, explicit marker var, test coverage
- Guard against overwriting terminal phases (PHASE:done, PHASE:merged)
  in on-stop-failure.sh to prevent false failures from same-turn race
- Declare sf_phase_marker explicitly in StopFailure block instead of
  relying on phase_marker from PostToolUse block
- Add authentication_failed test (10c) and terminal phase guard tests
  (10g, 10h)
- Fix fragile nested command substitution in test 10f fail() message

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-20 01:52:46 +00:00

42 lines
1.6 KiB
Bash
Executable file

#!/bin/bash
# on-stop-failure.sh — StopFailure hook for immediate phase file update on API error.
#
# Called by Claude Code when a turn ends due to an API error (rate limit,
# server error, billing error, authentication failure). Writes PHASE:failed
# to the phase file and touches the phase-changed marker so the orchestrator
# picks up the failure within one poll cycle instead of waiting for idle
# timeout (up to 2 hours).
#
# Usage (in .claude/settings.json):
# {"type": "command", "command": "this-script /path/to/phase-file /path/to/marker"}
#
# Args: $1 = phase file path, $2 = phase-changed marker path
phase_file="${1:-}"
marker_file="${2:-}"
[ -z "$phase_file" ] && exit 0
input=$(cat) # consume hook JSON from stdin
# Extract the stop reason from the hook payload
reason=$(printf '%s' "$input" | jq -r '
.stop_reason // .matched_hook // .reason // .type // "unknown"
' 2>/dev/null)
[ -z "$reason" ] && reason="unknown"
# Guard: do not overwrite a terminal phase. If Claude wrote PHASE:done via a
# tool call and then hit a rate limit while generating the rest of its response,
# the PostToolUse hook already recorded the correct terminal phase.
existing=$(head -1 "$phase_file" 2>/dev/null | tr -d '[:space:]')
case "$existing" in
PHASE:done|PHASE:merged) exit 0 ;;
esac
# Write phase file immediately — orchestrator reads first line as phase sentinel
printf 'PHASE:failed\nReason: api_error: %s\n' "$reason" > "$phase_file"
# Touch marker so monitor_phase_loop picks this up on the next poll cycle
if [ -n "$marker_file" ]; then
date +%s > "$marker_file"
fi