disinto-admin/disinto
1
0
Fork 0
Code Issues 15 Pull requests Projects Releases Packages Wiki Activity Actions

fix: extend step 8 approval-bias carve-out to include infra files (step 3c), fix count
All checks were successful
ci/woodpecker/push/ci Pipeline was successful
Details
ci/woodpecker/pr/ci Pipeline was successful
Details

Browse source 
- Step 8 now explicitly exempts infrastructure file findings (step 3c) from
  the "bias toward APPROVE" guidance, preventing the original failure mode
- Fix investigation summary: "Five" → "Six" structural gaps

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Claude 2026-04-11 19:50:59 +00:00
parent 527731da53
commit 810d92676c
2 changed files with 6 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
docs/investigation-685-reviewer-approved-destructive-compose.md
View file

@ -8,7 +8,7 @@
The reviewer agent approved PR #683 in ~1 minute without flagging that it The reviewer agent approved PR #683 in ~1 minute without flagging that it
contained a destructive rewrite of `docker-compose.yml` — dropping named contained a destructive rewrite of `docker-compose.yml` — dropping named
volumes, bind mounts, env vars, restart policy, and security options. Five volumes, bind mounts, env vars, restart policy, and security options. Six
structural gaps in the review pipeline allowed this to pass. structural gaps in the review pipeline allowed this to pass.
## Root causes ## Root causes

8
formulas/review-pr.toml
View file

@ -277,9 +277,11 @@ for actual problems (bugs, security issues, broken functionality, missing
required behavior). Use DISCUSS sparingly. required behavior). Use DISCUSS sparingly.
Note: The bias toward APPROVE applies to code correctness and style decisions. Note: The bias toward APPROVE applies to code correctness and style decisions.
It does NOT apply to documentation consistency (step 3b) or tech-debt filing It does NOT apply to documentation consistency (step 3b), infrastructure file
(step 7) — those are separate concerns that should be handled regardless of findings (step 3c), or tech-debt filing (step 7) — those are separate concerns
the change's correctness. that should be handled regardless of the change's correctness. In particular,
dropped production configuration (volumes, bind mounts, env vars, restart
policy) is a blocking defect, not a style preference.
## 9. Output ## 9. Output