fix: disinto init fails on re-run — admin password not persisted #158

New issue

Closed

opened 2026-04-02 20:58:00 +00:00 by dev-bot · 1 comment

dev-bot commented

2026-04-02 20:58:00 +00:00

Collaborator

Problem

bin/disinto init generates a random admin password on first run:

admin_pass="admin-$(head -c 16 /dev/urandom | base64 | tr -dc a-zA-Z0-9 | head -c 20)"

This password is stored only in the local variable _FORGE_ADMIN_PASS and is never written to .env. On re-run, init tries to authenticate as disinto-admin with a freshly generated random password, which fails:

Error: failed to obtain admin API token

Root cause

In bin/disinto, the forge_setup() function: the password is saved to _FORGE_ADMIN_PASS for Woodpecker OAuth2 token generation, but never persisted to .env. When the admin user already exists on re-run, the script skips creation but still needs to authenticate — and has no way to recover the password.

Expected behavior

Re-running disinto init should succeed idempotently. The admin password should either be:

Saved to .env (as FORGE_ADMIN_PASS) on first creation, then re-read on subsequent runs, OR
Reset via forgejo admin user change-password when the script detects it cannot authenticate

Steps to reproduce

bin/disinto init https://codeberg.org/johba/harb --branch master --yes — succeeds partially, creates admin + bots, then fails at preflight
bin/disinto init https://codeberg.org/johba/harb --branch master --yes — fails immediately with Error: failed to obtain admin API token

Files

bin/disinto — the forge_setup() function, admin user creation block and the token creation block below it

## Problem `bin/disinto init` generates a random admin password on first run: ```bash admin_pass="admin-$(head -c 16 /dev/urandom | base64 | tr -dc a-zA-Z0-9 | head -c 20)" ``` This password is stored only in the local variable `_FORGE_ADMIN_PASS` and is **never written to `.env`**. On re-run, init tries to authenticate as `disinto-admin` with a freshly generated random password, which fails: ``` Error: failed to obtain admin API token ``` ## Root cause In `bin/disinto`, the `forge_setup()` function: the password is saved to `_FORGE_ADMIN_PASS` for Woodpecker OAuth2 token generation, but never persisted to `.env`. When the admin user already exists on re-run, the script skips creation but still needs to authenticate — and has no way to recover the password. ## Expected behavior Re-running `disinto init` should succeed idempotently. The admin password should either be: 1. Saved to `.env` (as `FORGE_ADMIN_PASS`) on first creation, then re-read on subsequent runs, OR 2. Reset via `forgejo admin user change-password` when the script detects it cannot authenticate ## Steps to reproduce 1. `bin/disinto init https://codeberg.org/johba/harb --branch master --yes` — succeeds partially, creates admin + bots, then fails at preflight 2. `bin/disinto init https://codeberg.org/johba/harb --branch master --yes` — fails immediately with `Error: failed to obtain admin API token` ## Files - `bin/disinto` — the `forge_setup()` function, admin user creation block and the token creation block below it