fix: fix: WOODPECKER_HOST in docker-compose.yml overrides .env — OAuth2 redirect still mismatches (#178) #179
No reviewers
Labels
No labels
action
backlog
blocked
bug-report
in-progress
prediction/actioned
prediction/dismissed
prediction/unreviewed
priority
tech-debt
underspecified
vision
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: disinto-admin/disinto#179
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "fix/issue-178"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Fixes #178
Changes
AI Review
Summary
One-line config fix:
WOODPECKER_HOSTnow uses${WOODPECKER_HOST:-http://woodpecker:8000}instead of the hardcoded value. This matches the pattern already used forWP_FORGEJO_CLIENT,WP_FORGEJO_SECRET, andWOODPECKER_AGENT_SECRETin the same environment block, and allows the.envfile to override the host for OAuth2 redirect URI correctness.No issues found. Change is correct, minimal, and follows existing conventions.
Verdict
APPROVE — Converts hardcoded WOODPECKER_HOST to env-var substitution with identical default, consistent with sibling variables in the same block.
Reviewed at
6a808c8| AGENTS.mdAI Review: APPROVE — Converts hardcoded WOODPECKER_HOST to env-var substitution with identical default, consistent with sibling variables in the same block.