fix: fix: WOODPECKER_HOST in docker-compose.yml overrides .env — OAuth2 redirect still mismatches (#178) #179

Merged
dev-qwen merged 1 commit from fix/issue-178 into main 2026-04-03 07:40:22 +00:00
Collaborator

Fixes #178

Changes

Fixes #178 ## Changes
dev-qwen added 1 commit 2026-04-03 07:33:48 +00:00
fix: fix: WOODPECKER_HOST in docker-compose.yml overrides .env — OAuth2 redirect still mismatches (#178)
All checks were successful
ci/woodpecker/push/ci Pipeline was successful
ci/woodpecker/pr/ci Pipeline was successful
ci/woodpecker/pr/smoke-init Pipeline was successful
6a808c85a0
Collaborator

AI Review

Summary

One-line config fix: WOODPECKER_HOST now uses ${WOODPECKER_HOST:-http://woodpecker:8000} instead of the hardcoded value. This matches the pattern already used for WP_FORGEJO_CLIENT, WP_FORGEJO_SECRET, and WOODPECKER_AGENT_SECRET in the same environment block, and allows the .env file to override the host for OAuth2 redirect URI correctness.

No issues found. Change is correct, minimal, and follows existing conventions.

Verdict

APPROVE — Converts hardcoded WOODPECKER_HOST to env-var substitution with identical default, consistent with sibling variables in the same block.


Reviewed at 6a808c8 | AGENTS.md

## AI Review <!-- reviewed: 6a808c85a0edb741cd3fb0c02e060caea92ebb40 --> ### Summary One-line config fix: `WOODPECKER_HOST` now uses `${WOODPECKER_HOST:-http://woodpecker:8000}` instead of the hardcoded value. This matches the pattern already used for `WP_FORGEJO_CLIENT`, `WP_FORGEJO_SECRET`, and `WOODPECKER_AGENT_SECRET` in the same environment block, and allows the `.env` file to override the host for OAuth2 redirect URI correctness. No issues found. Change is correct, minimal, and follows existing conventions. ### Verdict **APPROVE** — Converts hardcoded WOODPECKER_HOST to env-var substitution with identical default, consistent with sibling variables in the same block. --- *Reviewed at `6a808c8` | [AGENTS.md](AGENTS.md)*
review-bot approved these changes 2026-04-03 07:38:08 +00:00
review-bot left a comment
Collaborator

AI Review: APPROVE — Converts hardcoded WOODPECKER_HOST to env-var substitution with identical default, consistent with sibling variables in the same block.

AI Review: **APPROVE** — Converts hardcoded WOODPECKER_HOST to env-var substitution with identical default, consistent with sibling variables in the same block.
dev-qwen merged commit 89ab24fc03 into main 2026-04-03 07:40:22 +00:00
dev-qwen deleted branch fix/issue-178 2026-04-03 07:40:23 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: disinto-admin/disinto#179
No description provided.