disinto-admin/disinto

Fork 0

fix: dev-poll.sh in-progress scan falls through on waiting PRs #185

New issue

Closed

opened 2026-04-03 12:22:41 +00:00 by dev-bot · 2 comments

dev-bot commented

2026-04-03 12:22:41 +00:00

Collaborator

Problem

In dev/dev-poll.sh, the PRIORITY 1 in-progress scan (line ~393) detects a PR in "waiting" state (CI passed, no review yet) but does not exit 0. It logs the waiting PR and falls through to the backlog scan, which can launch a new dev-agent for a different issue while the first agent is still walking its PR to merge.

How it manifests

Two dev-agents run concurrently: one walking PR #54 (review poll), the other implementing #43. Both hit llama-server simultaneously. The first agent's review cycle continues but the system is no longer single-threaded per project.

Root cause

Line ~393 in the in-progress scan:

else
    log "issue #${ISSUE_NUM} has open PR #${HAS_PR} (CI: ${CI_STATE}, waiting)"
fi
# falls through to backlog scan

This branch should exit 0 to prevent new work while a PR is pending review.

Fix

Add exit 0 after the log line in the else branch (~line 394), so the poll exits when it detects a PR waiting for review.

Context

Discovered on 2026-03-29 when lock cleanup + this bug combined to launch two agents concurrently. The lock check is the primary guard, but this should be the secondary defense.

## Problem In `dev/dev-poll.sh`, the PRIORITY 1 in-progress scan (line ~393) detects a PR in "waiting" state (CI passed, no review yet) but does not `exit 0`. It logs the waiting PR and falls through to the backlog scan, which can launch a new dev-agent for a different issue while the first agent is still walking its PR to merge. ## How it manifests Two dev-agents run concurrently: one walking PR #54 (review poll), the other implementing #43. Both hit llama-server simultaneously. The first agent's review cycle continues but the system is no longer single-threaded per project. ## Root cause Line ~393 in the in-progress scan: ```bash else log "issue #${ISSUE_NUM} has open PR #${HAS_PR} (CI: ${CI_STATE}, waiting)" fi # falls through to backlog scan ``` This branch should `exit 0` to prevent new work while a PR is pending review. ## Fix Add `exit 0` after the log line in the else branch (~line 394), so the poll exits when it detects a PR waiting for review. ## Context Discovered on 2026-03-29 when lock cleanup + this bug combined to launch two agents concurrently. The lock check is the primary guard, but this should be the secondary defense.

dev-bot added the

backlog

label 2026-04-03 12:22:41 +00:00

dev-qwen self-assigned this 2026-04-03 12:49:12 +00:00

dev-qwen added

in-progress

and removed

backlog

labels 2026-04-03 12:49:13 +00:00

dev-qwen commented

2026-04-03 12:50:26 +00:00

Collaborator

Blocked — issue #185

Field	Value
Exit reason	`no_push`
Timestamp	`2026-04-03T12:50:26Z`

Diagnostic output

Claude did not push branch fix/issue-185

### Blocked — issue #185 | Field | Value | |---|---| | Exit reason | `no_push` | | Timestamp | `2026-04-03T12:50:26Z` | <details><summary>Diagnostic output</summary> ``` Claude did not push branch fix/issue-185 ``` </details>

dev-qwen added

blocked

and removed

in-progress

labels 2026-04-03 12:50:26 +00:00

disinto-admin added

backlog

and removed

blocked

labels 2026-04-05 07:28:54 +00:00

dev-qwen added

in-progress

and removed

backlog

labels 2026-04-05 07:32:44 +00:00

dev-qwen commented

2026-04-05 07:38:12 +00:00

Collaborator

✅ Dev-agent: Already implemented

Existing implementation

The fix (exit 0 after the log line at line 415) is already present in dev/dev-poll.sh. The current state shows the else branch correctly exits when a PR is waiting for review, preventing the poll from falling through to the backlog scan.

Closing as already implemented.

Automated assessment by dev-agent · 2026-04-05 07:38 UTC

✅ **Dev-agent: Already implemented** ### Existing implementation The fix (exit 0 after the log line at line 415) is already present in dev/dev-poll.sh. The current state shows the else branch correctly exits when a PR is waiting for review, preventing the poll from falling through to the backlog scan. Closing as already implemented. --- *Automated assessment by dev-agent · 2026-04-05 07:38 UTC*

dev-qwen removed their assignment 2026-04-05 07:38:12 +00:00

dev-qwen closed this issue

2026-04-05 07:38:12 +00:00