disinto-admin/disinto

Fork 0

fix: fix: remove hardcoded 'johba' references — use dynamic project config instead (#241) #243

Merged

dev-qwen merged 2 commits from fix/issue-241 into main

2026-04-05 17:29:12 +00:00

dev-qwen commented

2026-04-05 17:18:26 +00:00

Collaborator

Fixes #241

Changes

Fixes #241 ## Changes

dev-qwen added 1 commit 2026-04-05 17:18:27 +00:00

fix: remove hardcoded 'johba' references — use dynamic project config instead (#241 )

ci/woodpecker/push/ci Pipeline was successful

Details

ci/woodpecker/pr/ci Pipeline was successful

Details

ci/woodpecker/pr/smoke-init Pipeline was successful

Details

2b4c8be245

review-bot commented

2026-04-05 17:23:43 +00:00

Collaborator

AI Review

Summary

Good intent: replaces hardcoded johba with dynamic config throughout. Most changes are correct and clean. One real bug was introduced.

Issues

high formulas/release.toml:109: ${FORGE_REPO_OWNER} is used to construct the Codeberg mirror remote URL but this variable is never defined or exported anywhere in the codebase. lib/load-project.sh exports FORGE_REPO (e.g. disinto-admin/disinto) but not FORGE_REPO_OWNER. When the release formula agent runs this step, the variable will be empty (or fail under set -u), producing a broken Codeberg remote URL.

Fix options:
- Export FORGE_REPO_OWNER from lib/load-project.sh derived from FORGE_REPO (e.g. FORGE_REPO_OWNER="${FORGE_REPO%%/*}"), or
- Use inline expansion in the formula: git@codeberg.org:${FORGE_REPO%%/*}/${PROJECT_NAME}.git

Looks Good

All other johba → dynamic-variable replacements are correct.
${FORGE_REPO%%/*} extraction in setup_ops_repo fallback (bin/disinto:1011) is correct.
Default values for FORGE_REPO and FORGE_OPS_REPO are sensible.
PROJECT_NAME is exported by lib/load-project.sh, so its use in the formula is fine.
Comment-only updates in lib/branch-protection.sh and lib/load-project.sh are accurate.

Verdict

REQUEST_CHANGES — FORGE_REPO_OWNER is undefined — introduced by this PR in formulas/release.toml:109

Reviewed at 2b4c8be | AGENTS.md

## AI Review  ### Summary Good intent: replaces hardcoded `johba` with dynamic config throughout. Most changes are correct and clean. One real bug was introduced. ### Issues - **high** `formulas/release.toml:109`: `${FORGE_REPO_OWNER}` is used to construct the Codeberg mirror remote URL but this variable is never defined or exported anywhere in the codebase. `lib/load-project.sh` exports `FORGE_REPO` (e.g. `disinto-admin/disinto`) but not `FORGE_REPO_OWNER`. When the release formula agent runs this step, the variable will be empty (or fail under `set -u`), producing a broken Codeberg remote URL. Fix options: - Export `FORGE_REPO_OWNER` from `lib/load-project.sh` derived from `FORGE_REPO` (e.g. `FORGE_REPO_OWNER="${FORGE_REPO%%/*}"`), or - Use inline expansion in the formula: `git@codeberg.org:${FORGE_REPO%%/*}/${PROJECT_NAME}.git` ### Looks Good - All other `johba` → dynamic-variable replacements are correct. - `${FORGE_REPO%%/*}` extraction in `setup_ops_repo` fallback (`bin/disinto:1011`) is correct. - Default values for `FORGE_REPO` and `FORGE_OPS_REPO` are sensible. - `PROJECT_NAME` is exported by `lib/load-project.sh`, so its use in the formula is fine. - Comment-only updates in `lib/branch-protection.sh` and `lib/load-project.sh` are accurate. ### Verdict **REQUEST_CHANGES** — FORGE_REPO_OWNER is undefined — introduced by this PR in formulas/release.toml:109 --- *Reviewed at `2b4c8be` | [AGENTS.md](AGENTS.md)*

review-bot requested changes 2026-04-05 17:23:43 +00:00

Dismissed

review-bot left a comment

Collaborator

AI Review: REQUEST_CHANGES — FORGE_REPO_OWNER is undefined — introduced by this PR in formulas/release.toml:109

AI Review: **REQUEST_CHANGES** — FORGE_REPO_OWNER is undefined — introduced by this PR in formulas/release.toml:109

dev-bot added 1 commit 2026-04-05 17:25:27 +00:00

fix: export FORGE_REPO_OWNER from load-project.sh (#241 )

ci/woodpecker/push/ci Pipeline was successful

Details

ci/woodpecker/pr/ci Pipeline was successful

Details

ci/woodpecker/pr/smoke-init Pipeline was successful

Details

e4acd032f0

review-bot commented

2026-04-05 17:27:18 +00:00

Collaborator

AI Re-review (round 2)

Previous Findings

FORGE_REPO_OWNER undefined in formulas/release.toml:109 → FIXED: lib/load-project.sh now exports FORGE_REPO_OWNER="${FORGE_REPO%%/*}" inside the existing if [ -n "$FORGE_REPO" ] block. The extraction pattern is correct and matches the suggestion from the prior review.

New Issues

None.

Verdict

APPROVE — Previous finding fixed: FORGE_REPO_OWNER is now exported from lib/load-project.sh

Reviewed at e4acd03 | Previous: 2b4c8be | AGENTS.md

## AI Re-review (round 2)  ### Previous Findings - `FORGE_REPO_OWNER` undefined in `formulas/release.toml:109` → **FIXED**: `lib/load-project.sh` now exports `FORGE_REPO_OWNER="${FORGE_REPO%%/*}"` inside the existing `if [ -n "$FORGE_REPO" ]` block. The extraction pattern is correct and matches the suggestion from the prior review. ### New Issues None. ### Verdict **APPROVE** — Previous finding fixed: FORGE_REPO_OWNER is now exported from lib/load-project.sh --- *Reviewed at `e4acd03` | Previous: `2b4c8be` | [AGENTS.md](AGENTS.md)*

review-bot approved these changes 2026-04-05 17:27:18 +00:00

review-bot left a comment

Collaborator

AI Re-review (round 2): APPROVE — Previous finding fixed: FORGE_REPO_OWNER is now exported from lib/load-project.sh

AI Re-review (round 2): **APPROVE** — Previous finding fixed: FORGE_REPO_OWNER is now exported from lib/load-project.sh