disinto-admin/disinto
1
0
Fork 0
Code Issues 6 Pull requests 3 Projects Releases Packages Wiki Activity Actions

fix: duplicated label ID lookup — ensure_blocked_label_id vs _ilc_ensure_label_id #282

New issue
Closed
opened 2026-04-06 09:21:33 +00:00 by dev-bot · 0 comments
dev-bot commented 2026-04-06 09:21:33 +00:00
Collaborator
Copy link

Problem

lib/ci-helpers.sh:13 defines ensure_blocked_label_id() with cache _BLOCKED_LABEL_ID.
lib/issue-lifecycle.sh:55 defines _ilc_ensure_label_id() with cache _ILC_LABEL_IDS.

Both create the 'blocked' label if missing. Both are sourced by dev-poll.sh, so the caches are independent and can cause duplicate API calls.

Fix

Remove ensure_blocked_label_id() from ci-helpers.sh. Update its callers to use _ilc_ensure_label_id from issue-lifecycle.sh (which is the more general implementation supporting any label name).

Affected files

  • lib/ci-helpers.sh (remove ensure_blocked_label_id)
  • Any callers of ensure_blocked_label_id (switch to _ilc_ensure_label_id)

Acceptance criteria

  • Only one label ID lookup function exists
  • No duplicate API calls for label creation
## Problem lib/ci-helpers.sh:13 defines ensure_blocked_label_id() with cache _BLOCKED_LABEL_ID. lib/issue-lifecycle.sh:55 defines _ilc_ensure_label_id() with cache _ILC_LABEL_IDS. Both create the 'blocked' label if missing. Both are sourced by dev-poll.sh, so the caches are independent and can cause duplicate API calls. ## Fix Remove ensure_blocked_label_id() from ci-helpers.sh. Update its callers to use _ilc_ensure_label_id from issue-lifecycle.sh (which is the more general implementation supporting any label name). ## Affected files - lib/ci-helpers.sh (remove ensure_blocked_label_id) - Any callers of ensure_blocked_label_id (switch to _ilc_ensure_label_id) ## Acceptance criteria - [ ] Only one label ID lookup function exists - [ ] No duplicate API calls for label creation
dev-bot added the
backlog
 label 2026-04-06 09:21:33 +00:00
dev-bot self-assigned this 2026-04-06 10:04:05 +00:00
dev-bot added
in-progress
 and removed
backlog
 labels 2026-04-06 10:04:05 +00:00
dev-bot removed their assignment 2026-04-06 10:09:03 +00:00
dev-bot removed the
in-progress
 label 2026-04-06 10:09:03 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
fix/issue-387
fix/issue-381
fix/issue-379
fix/issue-234
fix/issue-194
pr-137
pr-134
pr-133
pr-126
fix/issue-14
fix/issue-21
chore/gardener-20260327-0004
fix/issue-1
v0.1.0
Labels
Clear labels   
action

   
backlog

   
blocked

   
bug-report

   
in-progress

   
prediction/actioned

   
prediction/dismissed

   
prediction/unreviewed

   
priority

   
tech-debt

   
underspecified

   
vision
No labels
action
backlog
blocked
bug-report
in-progress
prediction/actioned
prediction/dismissed
prediction/unreviewed
priority
tech-debt
underspecified
vision
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: disinto-admin/disinto#282
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?