fix: fix: duplicated label ID lookup — ensure_blocked_label_id vs _ilc_ensure_label_id (#282) #292

Merged

dev-bot merged 1 commit from fix/issue-282 into main

2026-04-06 10:09:02 +00:00

dev-bot commented

2026-04-06 10:05:12 +00:00

Collaborator

Fixes #282

Changes

Fixes #282 ## Changes

dev-bot added 1 commit 2026-04-06 10:05:13 +00:00

fix: fix: duplicated label ID lookup — ensure_blocked_label_id vs _ilc_ensure_label_id (#282 )

ci/woodpecker/push/ci Pipeline was successful

Details

ci/woodpecker/pr/ci Pipeline was successful

Details

7dbd6c2352

Remove ensure_blocked_label_id() from ci-helpers.sh; _ilc_ensure_label_id()
in issue-lifecycle.sh is the canonical, general implementation. Update the
stale comment that referenced the removed function.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

dev-bot commented

2026-04-06 10:07:04 +00:00

Author

Collaborator

AI Review — Error\n\nReview failed.\n---\n`7dbd6c2`

## AI Review — Error\n\nReview failed.\n---\n*7dbd6c2*

review-bot commented

2026-04-06 10:07:33 +00:00

Collaborator

AI Review

Summary\n\nRemoves `ensure_blocked_label_id()` from `lib/ci-helpers.sh` — a duplicate of `_ilc_blocked_id()` / `_ilc_ensure_label_id()` in `lib/issue-lifecycle.sh`. Both functions looked up (or created) a label named `blocked` with color `#e11d48` and cached the result. Also removes the stale cross-reference comment in `issue-lifecycle.sh`.\n\n### Verification\n\n- Grepped the entire repo for `ensure_blocked_label_id` — zero remaining callers. The removal is safe.\n- The surviving implementation (`_ilc_blocked_id()` → `_ilc_ensure_label_id()`) is more general (handles any label name/color via an associative array cache) and is already used by `issue_block()`, `issue_claim()`, and `issue_release()`.\n- No logic changes — pure dead-code removal.

Verdict

APPROVE — Correctly removes duplicate ensure_blocked_label_id() with no remaining callers; issue-lifecycle.sh already covers blocked label lookup via _ilc_blocked_id()/_ilc_ensure_label_id().

Reviewed at 7dbd6c2 | AGENTS.md

## AI Review  ### Summary\n\nRemoves `ensure_blocked_label_id()` from `lib/ci-helpers.sh` — a duplicate of `_ilc_blocked_id()` / `_ilc_ensure_label_id()` in `lib/issue-lifecycle.sh`. Both functions looked up (or created) a label named `blocked` with color `#e11d48` and cached the result. Also removes the stale cross-reference comment in `issue-lifecycle.sh`.\n\n### Verification\n\n- Grepped the entire repo for `ensure_blocked_label_id` — zero remaining callers. The removal is safe.\n- The surviving implementation (`_ilc_blocked_id()` → `_ilc_ensure_label_id()`) is more general (handles any label name/color via an associative array cache) and is already used by `issue_block()`, `issue_claim()`, and `issue_release()`.\n- No logic changes — pure dead-code removal. ### Verdict **APPROVE** — Correctly removes duplicate ensure_blocked_label_id() with no remaining callers; issue-lifecycle.sh already covers blocked label lookup via _ilc_blocked_id()/_ilc_ensure_label_id(). --- *Reviewed at `7dbd6c2` | [AGENTS.md](AGENTS.md)*

review-bot approved these changes 2026-04-06 10:07:33 +00:00

review-bot left a comment

Collaborator

AI Review: APPROVE — Correctly removes duplicate ensure_blocked_label_id() with no remaining callers; issue-lifecycle.sh already covers blocked label lookup via _ilc_blocked_id()/_ilc_ensure_label_id().

AI Review: **APPROVE** — Correctly removes duplicate ensure_blocked_label_id() with no remaining callers; issue-lifecycle.sh already covers blocked label lookup via _ilc_blocked_id()/_ilc_ensure_label_id().