disinto up silently destroys profile-gated services #845

New issue

Closed

opened 2026-04-16 10:03:37 +00:00 by dev-bot · 1 comment

dev-bot commented

2026-04-16 10:03:37 +00:00

Collaborator

Problem

disinto up runs docker compose up -d --build --remove-orphans. When invoked without COMPOSE_PROFILES set, compose treats every service gated behind a profile (e.g. agents-llama) as an orphan and removes its container. Result: any naive disinto up silently kills the dev-qwen sidecar (and any other profile-gated agent).

Repro

Hire a llama agent (disinto hire-an-agent dev-qwen dev --local-model http://10.10.10.1:8081 ...) so the agents-llama profile service exists in compose.
Start it once with the profile active: COMPOSE_PROFILES=agents-llama disinto up.
Run plain disinto up without COMPOSE_PROFILES in .env.
docker ps | grep agents-llama → gone.

Fix options

Drop --remove-orphans from disinto up (simplest; sacrifices orphan cleanup).
hire-an-agent writes/merges COMPOSE_PROFILES into .env so profile persists across runs.
Emit the service block without a profile gate when the corresponding [agents.X] TOML entry is active — let TOML drive emission, not compose profiles.

Best long-term: option 3 — the profile gate is vestigial once TOML is canonical (see #846).

Acceptance

Running disinto up after hire-an-agent dev-qwen leaves disinto-agents-llama running.
No silent container destruction on subsequent disinto up calls.

Related: #846, #847.

## Problem `disinto up` runs `docker compose up -d --build --remove-orphans`. When invoked without `COMPOSE_PROFILES` set, compose treats every service gated behind a profile (e.g. `agents-llama`) as an orphan and removes its container. Result: any naive `disinto up` silently kills the dev-qwen sidecar (and any other profile-gated agent). ## Repro 1. Hire a llama agent (`disinto hire-an-agent dev-qwen dev --local-model http://10.10.10.1:8081 ...`) so the `agents-llama` profile service exists in compose. 2. Start it once with the profile active: `COMPOSE_PROFILES=agents-llama disinto up`. 3. Run plain `disinto up` without `COMPOSE_PROFILES` in `.env`. 4. `docker ps | grep agents-llama` → gone. ## Fix options - Drop `--remove-orphans` from `disinto up` (simplest; sacrifices orphan cleanup). - `hire-an-agent` writes/merges `COMPOSE_PROFILES` into `.env` so profile persists across runs. - Emit the service block without a profile gate when the corresponding `[agents.X]` TOML entry is active — let TOML drive emission, not compose profiles. Best long-term: option 3 — the profile gate is vestigial once TOML is canonical (see #846). ## Acceptance - Running `disinto up` after `hire-an-agent dev-qwen` leaves `disinto-agents-llama` running. - No silent container destruction on subsequent `disinto up` calls. Related: #846, #847.

dev-bot added the

Field	Value
Exit reason	`ci_exhausted_poll (3 attempts, PR #860)`
Timestamp	`2026-04-16T11:18:30Z`

Rows
Columns

disinto up silently destroys profile-gated services #845

Problem

Repro

Fix options

Acceptance

Blocked — issue #845