disinto-admin/disinto

Fork 0

fix: [nomad-step-5] S5-fix-6 — chat Dockerfile must bake Claude CLI (same as agents #984) (#1016) #1017

Merged

dev-qwen2 merged 2 commits from fix/issue-1016 into main

2026-04-18 13:10:10 +00:00

dev-qwen commented

2026-04-18 13:01:53 +00:00

Collaborator

Fixes #1016

Changes

Fixes #1016 ## Changes

dev-qwen added 1 commit 2026-04-18 13:01:54 +00:00

fix: [nomad-step-5] S5-fix-6 — chat Dockerfile must bake Claude CLI (same as agents #984 ) (#1016 )

ci/woodpecker/push/ci Pipeline was successful

Details

ci/woodpecker/pr/ci Pipeline was successful

Details

4f5e546c42

review-bot commented

2026-04-18 13:03:41 +00:00

Collaborator

AI Review

Blocker\n- blocker `docker/chat/Dockerfile:8-9`: Comment says "The claude binary is mounted from the host at runtime via docker-compose, not baked into the image" — this PR bakes it in. The comment directly contradicts the change and must be removed or updated before merge.\n\n### Rest of change\nVersion (`@anthropic-ai/claude-code@2.1.84`), install method (`npm install -g`), and `nodejs npm` apt dep all match the agents Dockerfile exactly. No existing config dropped.

Verdict

REQUEST_CHANGES — Stale comment still says binary is mounted at runtime — now the opposite of what the PR does

Reviewed at 4f5e546 | AGENTS.md

## AI Review  ### Blocker\n- **blocker** `docker/chat/Dockerfile:8-9`: Comment says _"The claude binary is mounted from the host at runtime via docker-compose, not baked into the image"_ — this PR bakes it in. The comment directly contradicts the change and must be removed or updated before merge.\n\n### Rest of change\nVersion (`@anthropic-ai/claude-code@2.1.84`), install method (`npm install -g`), and `nodejs npm` apt dep all match the agents Dockerfile exactly. No existing config dropped. ### Verdict **REQUEST_CHANGES** — Stale comment still says binary is mounted at runtime — now the opposite of what the PR does --- *Reviewed at `4f5e546` | [AGENTS.md](AGENTS.md)*

review-bot requested changes 2026-04-18 13:03:41 +00:00

Dismissed

review-bot left a comment

Collaborator

AI Review: REQUEST_CHANGES — Stale comment still says binary is mounted at runtime — now the opposite of what the PR does

AI Review: **REQUEST_CHANGES** — Stale comment still says binary is mounted at runtime — now the opposite of what the PR does

dev-qwen added 1 commit 2026-04-18 13:08:07 +00:00

fix: [nomad-step-5] S5-fix-6 — chat Dockerfile must bake Claude CLI (same as agents #984 ) (#1016 )

ci/woodpecker/push/ci Pipeline was successful

Details

ci/woodpecker/pr/ci Pipeline was successful

Details

38b55e1855

review-bot commented

2026-04-18 13:09:57 +00:00

Collaborator

AI Re-review (round 2)

Previous Findings\n- blocker `docker/chat/Dockerfile:8-9`: Stale comment contradicting bake-in change → FIXED: Comment now reads "Claude CLI is baked into the image — same pattern as the agents container."\n\n### New Issues\nNone.

Verdict

APPROVE — Prior blocker (stale mount-at-runtime comment) removed and replaced with accurate baked-in description; no collateral damage

Reviewed at 38b55e1 | Previous: 4f5e546 | AGENTS.md

## AI Re-review (round 2)  ### Previous Findings\n- **blocker** `docker/chat/Dockerfile:8-9`: Stale comment contradicting bake-in change → **FIXED**: Comment now reads "Claude CLI is baked into the image — same pattern as the agents container."\n\n### New Issues\nNone. ### Verdict **APPROVE** — Prior blocker (stale mount-at-runtime comment) removed and replaced with accurate baked-in description; no collateral damage --- *Reviewed at `38b55e1` | Previous: `4f5e546` | [AGENTS.md](AGENTS.md)*

review-bot approved these changes 2026-04-18 13:09:57 +00:00

review-bot left a comment

Collaborator

AI Re-review (round 2): APPROVE — Prior blocker (stale mount-at-runtime comment) removed and replaced with accurate baked-in description; no collateral damage

AI Re-review (round 2): **APPROVE** — Prior blocker (stale mount-at-runtime comment) removed and replaced with accurate baked-in description; no collateral damage