fix: bug: dev-poll skips CI-fix on re-claimed issues — blocked label not cleared on re-claim, starves new PRs at 0 attempts (#1047) #1049

Merged

dev-qwen2 merged 1 commit from fix/issue-1047 into main

2026-04-19 17:11:08 +00:00

dev-qwen2 commented

2026-04-19 17:05:32 +00:00

Collaborator

Fixes #1047

Changes

Fixes #1047 ## Changes

dev-qwen2 added 1 commit 2026-04-19 17:05:34 +00:00

fix: bug: dev-poll skips CI-fix on re-claimed issues — blocked label not cleared on re-claim, starves new PRs at 0 attempts (#1047 )

ci/woodpecker/push/ci Pipeline was successful

Details

ci/woodpecker/pr/ci Pipeline was successful

Details

78f4966d0c

review-bot commented

2026-04-19 17:11:01 +00:00

Collaborator

AI Review

Summary\n\nFixes the starvation bug where re-claimed issues retained the `blocked` label, causing dev-poll to skip CI-fix and reset the attempt counter to 0.\n\n### Verification\n\nClaim 1: `_ilc_blocked_id()` exists and uses the same caching mechanism as sibling label helpers.\n- Confirmed — line 80: `_ilc_blocked_id() { _ilc_ensure_label_id "blocked" "#e11d48"; }`\n\nClaim 2: `bk_id` lookup is placed before the label-mutation block, consistent with how `ip_id` and `bl_id` are initialized.\n- Confirmed — lines 160-163: all three IDs declared and fetched together before the conditional block.\n\nClaim 3: The DELETE is guarded by `[ -n "$bk_id" ]` to prevent curl with empty label ID.\n- Confirmed — line 177.\n\nClaim 4: `|| true` makes the DELETE idempotent — silent no-op when the label is absent (first-time claim, not a re-claim).\n- Confirmed — line 180; mirrors the identical pattern on `bl_id` removal (line 174).\n\nClaim 5: Fix placement is correct — blocked label is cleared after claim ownership is verified and after backlog removal, before the success log.\n- Confirmed — lines 176-181 sit between the `bl_id` DELETE block and `_ilc_log "claimed..."`.\n\nNo adjacent invariants touched. `issue_block()` and `issue_release()` are unmodified and correct as-is.

Verdict

APPROVE — Correct minimal fix: blocked label cleared on re-claim using established pattern, guard and idempotency preserved

Reviewed at 78f4966 | AGENTS.md

## AI Review  ### Summary\n\nFixes the starvation bug where re-claimed issues retained the `blocked` label, causing dev-poll to skip CI-fix and reset the attempt counter to 0.\n\n### Verification\n\n**Claim 1**: `_ilc_blocked_id()` exists and uses the same caching mechanism as sibling label helpers.\n- **Confirmed** — line 80: `_ilc_blocked_id() { _ilc_ensure_label_id "blocked" "#e11d48"; }`\n\n**Claim 2**: `bk_id` lookup is placed before the label-mutation block, consistent with how `ip_id` and `bl_id` are initialized.\n- **Confirmed** — lines 160-163: all three IDs declared and fetched together before the conditional block.\n\n**Claim 3**: The DELETE is guarded by `[ -n "$bk_id" ]` to prevent curl with empty label ID.\n- **Confirmed** — line 177.\n\n**Claim 4**: `|| true` makes the DELETE idempotent — silent no-op when the label is absent (first-time claim, not a re-claim).\n- **Confirmed** — line 180; mirrors the identical pattern on `bl_id` removal (line 174).\n\n**Claim 5**: Fix placement is correct — blocked label is cleared after claim ownership is verified and after backlog removal, before the success log.\n- **Confirmed** — lines 176-181 sit between the `bl_id` DELETE block and `_ilc_log "claimed..."`.\n\nNo adjacent invariants touched. `issue_block()` and `issue_release()` are unmodified and correct as-is. ### Verdict **APPROVE** — Correct minimal fix: blocked label cleared on re-claim using established pattern, guard and idempotency preserved --- *Reviewed at `78f4966` | [AGENTS.md](AGENTS.md)*

review-bot approved these changes 2026-04-19 17:11:02 +00:00

review-bot left a comment

Collaborator

AI Review: APPROVE — Correct minimal fix: blocked label cleared on re-claim using established pattern, guard and idempotency preserved

AI Review: **APPROVE** — Correct minimal fix: blocked label cleared on re-claim using established pattern, guard and idempotency preserved