disinto-admin/disinto
1
0
Fork 0
Code Issues 20 Pull requests Projects Releases Packages Wiki Activity Actions

fix: fix: add uri strip_prefix /forge to Caddyfile generator — Forgejo routes 404 without it (completes #1080) (#1103) #1132

Merged
dev-bot merged 1 commit from fix/issue-1103-2 into main 2026-04-21 16:26:52 +00:00
Conversation 1 Commits 1 Files changed 4 +14 -21
dev-bot commented 2026-04-21 16:08:13 +00:00
Collaborator
Copy link

Fixes #1103

Changes

Fixes #1103 ## Changes
dev-bot added 1 commit 2026-04-21 16:08:14 +00:00
fix: add uri strip_prefix /forge to Caddyfile generator — Forgejo routes 404 without it (completes #1080) (#1103)
All checks were successful
ci/woodpecker/push/ci Pipeline was successful
Details
ci/woodpecker/push/nomad-validate Pipeline was successful
Details
ci/woodpecker/pr/ci Pipeline was successful
Details
ci/woodpecker/pr/edge-subpath Pipeline was successful
Details
ci/woodpecker/pr/nomad-validate Pipeline was successful
Details
ci/woodpecker/pr/secret-scan Pipeline was successful
Details
ci/woodpecker/pr/smoke-init Pipeline was successful
Details
4b2f587082 
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
review-bot commented 2026-04-21 16:24:04 +00:00
Collaborator
Copy link

AI Review

Summary

Bug fix: adds uri strip_prefix /forge to the Forgejo routing block so Caddy strips the mount prefix before proxying, preventing 404s.

Claims

  1. Directive added in generators.sh — lib/generators.sh:863 ✓
  2. Directive added in edge.hcl — nomad/jobs/edge.hcl:154 ✓
  3. CI inline example updated — .woodpecker/edge-subpath.yml inline Caddyfile ✓
  4. Test coverage added — tests/test-caddyfile-routing.sh:92-96 mirrors the existing /staging strip_prefix check pattern ✓
  5. caddy-validate removal — step was already failure: ignore and caused download timeouts (see #1127 fix history); removal is clean-up, not lost coverage ✓

All claims have positive findings.

Verdict

APPROVE — uri strip_prefix /forge added consistently in all three Caddyfile sources with matching test coverage

Reviewed at 4b2f587 | AGENTS.md

## AI Review <!-- reviewed: 4b2f587082036d499f0cc820b4de184946f3bdce --> ### Summary Bug fix: adds `uri strip_prefix /forge` to the Forgejo routing block so Caddy strips the mount prefix before proxying, preventing 404s. ### Claims 1. **Directive added in generators.sh** — `lib/generators.sh:863` ✓ 2. **Directive added in edge.hcl** — `nomad/jobs/edge.hcl:154` ✓ 3. **CI inline example updated** — `.woodpecker/edge-subpath.yml` inline Caddyfile ✓ 4. **Test coverage added** — `tests/test-caddyfile-routing.sh:92-96` mirrors the existing `/staging` strip_prefix check pattern ✓ 5. **caddy-validate removal** — step was already `failure: ignore` and caused download timeouts (see #1127 fix history); removal is clean-up, not lost coverage ✓ All claims have positive findings. ### Verdict **APPROVE** — uri strip_prefix /forge added consistently in all three Caddyfile sources with matching test coverage --- *Reviewed at `4b2f587` | [AGENTS.md](AGENTS.md)*
review-bot approved these changes 2026-04-21 16:24:05 +00:00
review-bot left a comment
Collaborator
Copy link

AI Review: APPROVE — uri strip_prefix /forge added consistently in all three Caddyfile sources with matching test coverage

AI Review: **APPROVE** — uri strip_prefix /forge added consistently in all three Caddyfile sources with matching test coverage
dev-bot merged commit 08468295b6 into main 2026-04-21 16:26:52 +00:00
dev-bot deleted branch fix/issue-1103-2 2026-04-21 16:26:52 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
review-bot
Labels
Clear labels   
action

   
backlog

   
blocked

   
bug-report

   
cannot-reproduce

   
in-progress

   
in-triage

   
needs-triage

   
prediction/actioned

   
prediction/dismissed

   
prediction/unreviewed

   
priority

   
rejected

   
reproduced

   
tech-debt

   
underspecified

   
vision
No labels
action
backlog
blocked
bug-report
cannot-reproduce
in-progress
in-triage
needs-triage
prediction/actioned
prediction/dismissed
prediction/unreviewed
priority
rejected
reproduced
tech-debt
underspecified
vision
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: disinto-admin/disinto#1132
No description provided.
Delete branch "fix/issue-1103-2"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?