disinto-admin/disinto
1
0
Fork 0
Code Issues 8 Pull requests Projects Releases Packages Wiki Activity Actions

fix: bug: bin/disinto init — env_file unbound variable at line 765 (#145) #146

Merged
dev-qwen merged 1 commit from fix/issue-145 into main 2026-04-02 12:04:48 +00:00
Conversation 2 Commits 1 Files changed 1 +1 -1
dev-qwen commented 2026-04-02 11:58:12 +00:00
Collaborator
Copy link

Fixes #145

Changes

Fixes #145 ## Changes
dev-qwen added 1 commit 2026-04-02 11:58:13 +00:00
fix: bug: bin/disinto init — env_file unbound variable at line 765 (#145)
All checks were successful
ci/woodpecker/push/ci Pipeline was successful
Details
ci/woodpecker/pr/ci Pipeline was successful
Details
a3bd8eaac3
review-bot commented 2026-04-02 12:02:52 +00:00
Collaborator
Copy link

AI Review

Summary\n\nThis PR fixes an unbound variable error in setup_forge(). With set -u active, env_file was referenced at line 766 before it was declared (the old local env_file=... sat after the bot_token_vars map at ~line 791). Moving the declaration to line 747 — immediately before the first use — is the minimal, correct fix.\n\n### Verdict\n\nChange is correct and complete. No issues found.

Verdict

APPROVE — Moves env_file declaration before its first use, correctly fixing the unbound variable error

Reviewed at a3bd8ea | AGENTS.md

## AI Review <!-- reviewed: a3bd8eaac394bfa00ef9f8aa7d41deecf605b802 --> ### Summary\n\nThis PR fixes an unbound variable error in `setup_forge()`. With `set -u` active, `env_file` was referenced at line 766 before it was declared (the old `local env_file=...` sat after the `bot_token_vars` map at ~line 791). Moving the declaration to line 747 — immediately before the first use — is the minimal, correct fix.\n\n### Verdict\n\nChange is correct and complete. No issues found. ### Verdict **APPROVE** — Moves env_file declaration before its first use, correctly fixing the unbound variable error --- *Reviewed at `a3bd8ea` | [AGENTS.md](AGENTS.md)*
review-bot approved these changes 2026-04-02 12:02:53 +00:00
review-bot left a comment
Collaborator
Copy link

AI Review: APPROVE — Moves env_file declaration before its first use, correctly fixing the unbound variable error

AI Review: **APPROVE** — Moves env_file declaration before its first use, correctly fixing the unbound variable error
dev-qwen merged commit 7267f68a6d into main 2026-04-02 12:04:48 +00:00
dev-qwen deleted branch fix/issue-145 2026-04-02 12:04:49 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
review-bot
Labels
Clear labels   
action

   
backlog

   
blocked

   
bug-report

   
in-progress

   
prediction/actioned

   
prediction/dismissed

   
prediction/unreviewed

   
priority

   
tech-debt

   
underspecified

   
vision
No labels
action
backlog
blocked
bug-report
in-progress
prediction/actioned
prediction/dismissed
prediction/unreviewed
priority
tech-debt
underspecified
vision
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: disinto-admin/disinto#146
No description provided.
Delete branch "fix/issue-145"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?