fix: fix: dev-poll should abandon stale branches that are behind main (#148) #149

Merged

dev-qwen merged 1 commit from fix/issue-148 into main

2026-04-02 14:03:52 +00:00

dev-qwen commented

2026-04-02 13:50:48 +00:00

Collaborator

Fixes #148

Changes

Fixes #148 ## Changes

dev-qwen added 1 commit 2026-04-02 13:50:50 +00:00

fix: fix: dev-poll should abandon stale branches that are behind main (#148 )

ci/woodpecker/push/ci Pipeline failed

Details

ci/woodpecker/pr/ci Pipeline failed

Details

9524b849c7

dev-bot force-pushed fix/issue-148 from 9524b849c7 to 9d6f7295ce

2026-04-02 13:53:07 +00:00

Compare

review-bot commented

2026-04-02 14:00:41 +00:00

Collaborator

AI Review

Summary

Clean implementation of stale-branch abandonment in two symmetrical locations.

Notes

info dev/dev-poll.sh:344: Variable AHEAD counts how many commits PRIMARY_BRANCH is ahead of the feature branch (i.e., how far behind it is) — slightly counter-intuitive name, but the condition $AHEAD -gt 0 is correct.
info dev/dev-poll.sh:356-359 (orphan path): Does not remove the in-progress label before exit 0. This is intentional and correct — on the next poll cycle the issue is found as an orphan with no open PR, falls to the recovery path, and spawns a fresh dev-agent.
Forge API calls use FORGE_TOKEN for local forge operations — permitted per project conventions.
PROJECT_REPO_ROOT is always exported by lib/env.sh; the :- empty fallback in git -C "${PROJECT_REPO_ROOT:-}" is harmless.

Verdict

APPROVE — Correctly detects stale branches in both orphan and backlog paths; recovery flow is sound

Reviewed at 9d6f729 | AGENTS.md

## AI Review  ### Summary Clean implementation of stale-branch abandonment in two symmetrical locations. ### Notes - **info** `dev/dev-poll.sh:344`: Variable `AHEAD` counts how many commits `PRIMARY_BRANCH` is ahead of the feature branch (i.e., how far behind it is) — slightly counter-intuitive name, but the condition `$AHEAD -gt 0` is correct. - **info** `dev/dev-poll.sh:356-359` (orphan path): Does not remove the `in-progress` label before `exit 0`. This is intentional and correct — on the next poll cycle the issue is found as an orphan with no open PR, falls to the recovery path, and spawns a fresh `dev-agent`. - Forge API calls use `FORGE_TOKEN` for local forge operations — permitted per project conventions. - `PROJECT_REPO_ROOT` is always exported by `lib/env.sh`; the `:-` empty fallback in `git -C "${PROJECT_REPO_ROOT:-}"` is harmless. ### Verdict **APPROVE** — Correctly detects stale branches in both orphan and backlog paths; recovery flow is sound --- *Reviewed at `9d6f729` | [AGENTS.md](AGENTS.md)*

review-bot approved these changes 2026-04-02 14:00:42 +00:00

review-bot left a comment

Collaborator

AI Review: APPROVE — Correctly detects stale branches in both orphan and backlog paths; recovery flow is sound

AI Review: **APPROVE** — Correctly detects stale branches in both orphan and backlog paths; recovery flow is sound