fix: fix: disinto init repo creation silently fails — wrong API endpoint for user namespace (#164) #165

Merged

dev-bot merged 1 commit from fix/issue-164 into main

2026-04-03 06:00:31 +00:00

dev-bot commented

2026-04-03 05:53:56 +00:00

Collaborator

Fixes #164

Changes

Fixes #164 ## Changes

dev-bot added 1 commit 2026-04-03 05:53:57 +00:00

fix: fix: disinto init repo creation silently fails — wrong API endpoint for user namespace (#164 )

ci/woodpecker/push/ci Pipeline was successful

Details

ci/woodpecker/pr/ci Pipeline was successful

Details

ci/woodpecker/pr/smoke-init Pipeline was successful

Details

5324d5fcfb

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

review-bot commented

2026-04-03 05:58:59 +00:00

Collaborator

AI Review

Summary

This PR fixes a silent failure in setup_forge(): the original fallback used POST /api/v1/users/${human_user}/repos which is not a valid Forgejo endpoint for repo creation (it's the token-listing path). The fix replaces it with the correct endpoints:

Admin path: POST /api/v1/admin/users/${org_name}/repos — the proper Forgejo admin API for creating a repo under a specific user account
User path: POST /api/v1/user/repos — the authenticated user's own repo creation endpoint

Error handling is also improved: the old code silently swallowed failures with || true; the new code exits with a descriptive error message if both fallback paths fail.

Findings

info bin/disinto:928-936: The HUMAN_TOKEN fallback uses POST /api/v1/user/repos, which creates the repo under johba's namespace. Subsequent collaborator operations at line 964 use ${repo_slug} (e.g. someorg/repo), so if org_name != johba the collaborator calls would 404 against the wrong path. In practice the fallback is only reached when org_name is the human user ("johba"), so this is unlikely to cause real breakage — but it's worth noting as a latent edge case.

Verdict

The core bug is correctly fixed. The API endpoints are now valid, the token preference order (admin > human > error) is sensible, and the change converts silent failure into explicit, actionable error messages. The edge case above is pre-existing by design and not introduced by this PR.

Verdict

APPROVE — Correct fix: replaces invalid Forgejo endpoint with proper admin/user APIs and adds explicit error handling

Reviewed at 5324d5f | AGENTS.md

## AI Review  ### Summary This PR fixes a silent failure in `setup_forge()`: the original fallback used `POST /api/v1/users/${human_user}/repos` which is not a valid Forgejo endpoint for repo creation (it's the token-listing path). The fix replaces it with the correct endpoints: - **Admin path**: `POST /api/v1/admin/users/${org_name}/repos` — the proper Forgejo admin API for creating a repo under a specific user account - **User path**: `POST /api/v1/user/repos` — the authenticated user's own repo creation endpoint Error handling is also improved: the old code silently swallowed failures with `|| true`; the new code exits with a descriptive error message if both fallback paths fail. ### Findings - **info** `bin/disinto:928-936`: The `HUMAN_TOKEN` fallback uses `POST /api/v1/user/repos`, which creates the repo under johba's namespace. Subsequent collaborator operations at line 964 use `${repo_slug}` (e.g. `someorg/repo`), so if `org_name != johba` the collaborator calls would 404 against the wrong path. In practice the fallback is only reached when `org_name` is the human user ("johba"), so this is unlikely to cause real breakage — but it's worth noting as a latent edge case. ### Verdict The core bug is correctly fixed. The API endpoints are now valid, the token preference order (admin > human > error) is sensible, and the change converts silent failure into explicit, actionable error messages. The edge case above is pre-existing by design and not introduced by this PR. ### Verdict **APPROVE** — Correct fix: replaces invalid Forgejo endpoint with proper admin/user APIs and adds explicit error handling --- *Reviewed at `5324d5f` | [AGENTS.md](AGENTS.md)*

review-bot approved these changes 2026-04-03 05:59:00 +00:00

review-bot left a comment

Collaborator

AI Review: APPROVE — Correct fix: replaces invalid Forgejo endpoint with proper admin/user APIs and adds explicit error handling

AI Review: **APPROVE** — Correct fix: replaces invalid Forgejo endpoint with proper admin/user APIs and adds explicit error handling