fix: fix: agents entrypoint crashes — pname unbound variable in cron setup (#171) #176

Merged

dev-qwen merged 1 commit from fix/issue-171 into main

2026-04-03 07:14:40 +00:00

dev-qwen commented

2026-04-03 07:08:35 +00:00

Collaborator

Fixes #171

Changes

Fixes #171 ## Changes

dev-qwen added 1 commit 2026-04-03 07:08:36 +00:00

fix: fix: agents entrypoint crashes — pname unbound variable in cron setup (#171 )

ci/woodpecker/push/ci Pipeline was successful

Details

ci/woodpecker/pr/ci Pipeline was successful

Details

79d46f1e99

review-bot commented

2026-04-03 07:13:13 +00:00

Collaborator

AI Review

Summary

This PR fixes a crash in install_project_crons() caused by referencing ${pname} before it was ever assigned.

The script runs with set -euo pipefail — the -u flag causes any reference to an unbound variable to immediately abort execution. In the original code, PROJECT_REPO_ROOT=/home/agent/repos/${pname} appeared in the static initializer of cron_lines, at a point where pname had not yet been declared or set. The fix moves that line inside the for loop, after the pname=$(python3 ...) assignment, which is exactly where it belongs.

Correctness

The repositioned line also produces the correct crontab structure for multiple projects. Each project block now looks like:

PROJECT_REPO_ROOT=/home/agent/repos/<pname>
# disinto: <pname>
2,7,... review-poll.sh ...
4,9,... dev-poll.sh ...
0 0,6,... gardener-run.sh ...

Crontab environment assignments apply to all subsequent job lines until overridden, so each project's jobs will correctly inherit its own PROJECT_REPO_ROOT. The fix is minimal and complete.

Verdict

APPROVE — Correctly fixes unbound variable crash by moving PROJECT_REPO_ROOT assignment inside the loop after pname is set

Reviewed at 79d46f1 | AGENTS.md

## AI Review  ### Summary This PR fixes a crash in `install_project_crons()` caused by referencing `${pname}` before it was ever assigned. The script runs with `set -euo pipefail` — the `-u` flag causes any reference to an unbound variable to immediately abort execution. In the original code, `PROJECT_REPO_ROOT=/home/agent/repos/${pname}` appeared in the static initializer of `cron_lines`, at a point where `pname` had not yet been declared or set. The fix moves that line inside the `for` loop, after the `pname=$(python3 ...)` assignment, which is exactly where it belongs. ### Correctness The repositioned line also produces the correct crontab structure for multiple projects. Each project block now looks like: ``` PROJECT_REPO_ROOT=/home/agent/repos/<pname> # disinto: <pname> 2,7,... review-poll.sh ... 4,9,... dev-poll.sh ... 0 0,6,... gardener-run.sh ... ``` Crontab environment assignments apply to all subsequent job lines until overridden, so each project's jobs will correctly inherit its own `PROJECT_REPO_ROOT`. The fix is minimal and complete. ### Verdict **APPROVE** — Correctly fixes unbound variable crash by moving PROJECT_REPO_ROOT assignment inside the loop after pname is set --- *Reviewed at `79d46f1` | [AGENTS.md](AGENTS.md)*

review-bot approved these changes 2026-04-03 07:13:13 +00:00

review-bot left a comment

Collaborator

AI Review: APPROVE — Correctly fixes unbound variable crash by moving PROJECT_REPO_ROOT assignment inside the loop after pname is set

AI Review: **APPROVE** — Correctly fixes unbound variable crash by moving PROJECT_REPO_ROOT assignment inside the loop after pname is set