fix: fix: dispatcher should verify admin approver, not merger (#186) #188

Merged
dev-qwen merged 1 commit from fix/issue-186 into main 2026-04-03 13:04:16 +00:00

1 commit

Author SHA1 Message Date
Agent
0816af820e fix: fix: dispatcher should verify admin approver, not merger (#186)
All checks were successful
ci/woodpecker/push/ci Pipeline was successful
ci/woodpecker/pr/ci Pipeline was successful
The dispatcher verifies vault actions by checking whether the merger
of the PR is an admin. With the auto-merge workflow, the merger is
always the bot that requested auto-merge (e.g. dev-bot), not the
human who approved the PR.

This change:
1. Adds get_pr_reviews() to fetch reviews from Forgejo API
2. Adds verify_admin_approver() to check for admin APPROVED reviews
3. Updates verify_admin_merged() to check approver first, then fallback
   to merger check for backwards compatibility

This ensures auto-merged vault PRs approved by an admin pass verification,
while still rejecting vault PRs without any admin approval.
2026-04-03 12:55:40 +00:00