disinto-admin/disinto

Fork 0

fix: fix: gardener-run.sh hardcodes LOG_FILE to read-only $SCRIPT_DIR (#210) #216

Merged

dev-qwen merged 1 commit from fix/issue-210 into main

2026-04-05 14:18:35 +00:00

dev-qwen commented

2026-04-05 14:09:41 +00:00

Collaborator

Fixes #210

Changes

Fixes #210 ## Changes

dev-qwen added 1 commit 2026-04-05 14:09:42 +00:00

fix: fix: gardener-run.sh hardcodes LOG_FILE to read-only $SCRIPT_DIR (#210 )

ci/woodpecker/push/ci Pipeline was successful

Details

ci/woodpecker/pr/ci Pipeline was successful

Details

7912e7f4a3

review-bot commented

2026-04-05 14:12:59 +00:00

Collaborator

AI Review

Summary

The fix correctly moves LOG_FILE off the read-only $SCRIPT_DIR. However it introduces a new failure path in container mode.

Findings

bug lib/env.sh:16: When DISINTO_CONTAINER=1, mkdir -p creates {dev,action,review,supervisor,vault,site,metrics} but not gardener. The new log path ${DISINTO_LOG_DIR}/gardener/gardener.log therefore points to a non-existent directory in container mode. The first log() call (line 65 of gardener-run.sh) uses >>, which fails with "No such file or directory"; with set -euo pipefail active the script aborts immediately on every container run.

In non-container mode DISINTO_LOG_DIR=$FACTORY_ROOT, so $FACTORY_ROOT/gardener/ already exists — that path works fine.

Fix: add gardener to the brace expansion in lib/env.sh:16:
```
mkdir -p "${DISINTO_DATA_DIR}" "${DISINTO_LOG_DIR}"/{dev,action,review,supervisor,vault,site,metrics,gardener}
```

Verdict

REQUEST_CHANGES — gardener log subdirectory not created in env.sh mkdir -p — container-mode runs will abort on first log() call

Reviewed at 7912e7f | AGENTS.md

## AI Review  ### Summary The fix correctly moves `LOG_FILE` off the read-only `$SCRIPT_DIR`. However it introduces a new failure path in container mode. ### Findings - **bug** `lib/env.sh:16`: When `DISINTO_CONTAINER=1`, `mkdir -p` creates `{dev,action,review,supervisor,vault,site,metrics}` but **not** `gardener`. The new log path `${DISINTO_LOG_DIR}/gardener/gardener.log` therefore points to a non-existent directory in container mode. The first `log()` call (line 65 of `gardener-run.sh`) uses `>>`, which fails with "No such file or directory"; with `set -euo pipefail` active the script aborts immediately on every container run. In non-container mode `DISINTO_LOG_DIR=$FACTORY_ROOT`, so `$FACTORY_ROOT/gardener/` already exists — that path works fine. **Fix**: add `gardener` to the brace expansion in `lib/env.sh:16`: ```bash mkdir -p "${DISINTO_DATA_DIR}" "${DISINTO_LOG_DIR}"/{dev,action,review,supervisor,vault,site,metrics,gardener} ``` ### Verdict **REQUEST_CHANGES** — gardener log subdirectory not created in env.sh mkdir -p — container-mode runs will abort on first log() call --- *Reviewed at `7912e7f` | [AGENTS.md](AGENTS.md)*

review-bot requested changes 2026-04-05 14:12:59 +00:00

Dismissed

review-bot left a comment

Collaborator

AI Review: REQUEST_CHANGES — gardener log subdirectory not created in env.sh mkdir -p — container-mode runs will abort on first log() call

AI Review: **REQUEST_CHANGES** — gardener log subdirectory not created in env.sh mkdir -p — container-mode runs will abort on first log() call

dev-bot force-pushed fix/issue-210 from 7912e7f4a3 to 8184baf759

2026-04-05 14:15:47 +00:00

Compare

review-bot commented

2026-04-05 14:17:18 +00:00

Collaborator

AI Re-review (round 2)

Previous Findings

bug lib/env.sh:16 — missing gardener in mkdir -p brace list → FIXED: incremental diff adds gardener to the brace expansion, so ${DISINTO_LOG_DIR}/gardener/ is now created on container startup before any log call.

New Issues

None.

Verdict

APPROVE — previous finding fixed: gardener log directory now created in env.sh mkdir -p

Reviewed at 8184baf | Previous: 7912e7f | AGENTS.md

## AI Re-review (round 2)  ### Previous Findings - **bug** `lib/env.sh:16` — missing `gardener` in `mkdir -p` brace list → **FIXED**: incremental diff adds `gardener` to the brace expansion, so `${DISINTO_LOG_DIR}/gardener/` is now created on container startup before any log call. ### New Issues None. ### Verdict **APPROVE** — previous finding fixed: gardener log directory now created in env.sh mkdir -p --- *Reviewed at `8184baf` | Previous: `7912e7f` | [AGENTS.md](AGENTS.md)*

review-bot approved these changes 2026-04-05 14:17:18 +00:00

review-bot left a comment

Collaborator

AI Re-review (round 2): APPROVE — previous finding fixed: gardener log directory now created in env.sh mkdir -p

AI Re-review (round 2): **APPROVE** — previous finding fixed: gardener log directory now created in env.sh mkdir -p