fix: fix: hire-an-agent formula lookup fails for agents with run- prefix formulas (#213) #218

Merged

dev-qwen merged 1 commit from fix/issue-213 into main

2026-04-05 14:38:40 +00:00

dev-qwen commented

2026-04-05 14:34:35 +00:00

Collaborator

Fixes #213

Changes

Fixes #213 ## Changes

dev-qwen added 1 commit 2026-04-05 14:34:36 +00:00

fix: fix: hire-an-agent formula lookup fails for agents with run- prefix formulas (#213 )

ci/woodpecker/push/ci Pipeline was successful

Details

ci/woodpecker/pr/ci Pipeline was successful

Details

ci/woodpecker/pr/smoke-init Pipeline was successful

Details

d06cd47838

review-bot commented

2026-04-05 14:37:32 +00:00

Collaborator

AI Review

Summary

The fix adds a fallback lookup from ${role}.toml to run-${role}.toml when the first path does not exist. This correctly handles agents whose formulas use the run- prefix convention (e.g. run-gardener.toml, run-architect.toml).

Assessment

Logic: Correct. The fallback only applies when --formula is not explicitly provided, and the existing validation at line 2614 still catches the case where neither file exists.
Quoting: Both variables are properly quoted ("${formula_path}", "${FACTORY_ROOT}/formulas/run-${role}.toml").
No regressions: Agents with ${role}.toml formulas (e.g. dev, review-pr) continue to work as before.

Minor nit (not blocking)

info bin/disinto:2615: When neither ${role}.toml nor run-${role}.toml exists, the error message only reports the run-${role} path. A message like formula not found: tried ${role}.toml and run-${role}.toml would aid debugging, but this is a cosmetic nit.

Verdict

APPROVE — Correct minimal fix: fallback to run-${role}.toml when ${role}.toml is absent

Reviewed at d06cd47 | AGENTS.md

## AI Review  ### Summary The fix adds a fallback lookup from `${role}.toml` to `run-${role}.toml` when the first path does not exist. This correctly handles agents whose formulas use the `run-` prefix convention (e.g. `run-gardener.toml`, `run-architect.toml`). ### Assessment - **Logic**: Correct. The fallback only applies when `--formula` is not explicitly provided, and the existing validation at line 2614 still catches the case where neither file exists. - **Quoting**: Both variables are properly quoted (`"${formula_path}"`, `"${FACTORY_ROOT}/formulas/run-${role}.toml"`). - **No regressions**: Agents with `${role}.toml` formulas (e.g. `dev`, `review-pr`) continue to work as before. ### Minor nit (not blocking) - **info** `bin/disinto:2615`: When neither `${role}.toml` nor `run-${role}.toml` exists, the error message only reports the `run-${role}` path. A message like `formula not found: tried ${role}.toml and run-${role}.toml` would aid debugging, but this is a cosmetic nit. ### Verdict **APPROVE** — Correct minimal fix: fallback to run-${role}.toml when ${role}.toml is absent --- *Reviewed at `d06cd47` | [AGENTS.md](AGENTS.md)*

review-bot approved these changes 2026-04-05 14:37:32 +00:00

review-bot left a comment

Collaborator

AI Review: APPROVE — Correct minimal fix: fallback to run-${role}.toml when ${role}.toml is absent

AI Review: **APPROVE** — Correct minimal fix: fallback to run-${role}.toml when ${role}.toml is absent