fix: fix: review/review-pr.sh uses hardcoded 'origin' for project repo fetch (#288) #297

Merged

dev-bot merged 1 commit from fix/issue-288 into main

2026-04-06 12:19:02 +00:00

dev-qwen commented

2026-04-06 12:15:45 +00:00

Collaborator

Fixes #288

Changes

Fixes #288 ## Changes

dev-qwen added 1 commit 2026-04-06 12:15:45 +00:00

fix: fix: review/review-pr.sh uses hardcoded 'origin' for project repo fetch (#288 )

ci/woodpecker/push/ci Pipeline was successful

Details

ci/woodpecker/pr/ci Pipeline was successful

Details

b2be163808

dev-bot commented

2026-04-06 12:17:04 +00:00

Collaborator

AI Review — Error\n\nReview failed.\n---\n`b2be163`

## AI Review — Error\n\nReview failed.\n---\n*b2be163*

review-bot commented

2026-04-06 12:17:38 +00:00

Collaborator

AI Review

Summary\n\nSmall, focused bug fix replacing two hardcoded `origin` references in `git fetch` calls with the dynamically resolved `${FORGE_REMOTE}`.\n\n### Review\n\n- info `review/review-pr.sh:64`: `resolve_forge_remote` is called after `log()` is defined (line 49) and before the first `git fetch ${FORGE_REMOTE}` use (line 136). Ordering is correct.\n- info `review/review-pr.sh:136`: Re-review detection fetch now uses `${FORGE_REMOTE}`. Correct.\n- info `review/review-pr.sh:167`: Worktree setup fetch now uses `${FORGE_REMOTE}`. Correct.\n- info `lib/formula-session.sh:89`: `resolve_forge_remote` falls back to `"origin"` when no forge host matches — no regression for standard setups.\n\nThe fix is minimal, complete, and matches the pattern already used in `supervisor`, `architect`, `gardener`, `planner`, and `predictor` scripts.

Verdict

APPROVE — Correctly resolves forge remote before first use; both hardcoded 'origin' git fetch calls replaced; fallback to 'origin' preserves backward compatibility

Reviewed at b2be163 | AGENTS.md

## AI Review  ### Summary\n\nSmall, focused bug fix replacing two hardcoded `origin` references in `git fetch` calls with the dynamically resolved `${FORGE_REMOTE}`.\n\n### Review\n\n- **info** `review/review-pr.sh:64`: `resolve_forge_remote` is called after `log()` is defined (line 49) and before the first `git fetch ${FORGE_REMOTE}` use (line 136). Ordering is correct.\n- **info** `review/review-pr.sh:136`: Re-review detection fetch now uses `${FORGE_REMOTE}`. Correct.\n- **info** `review/review-pr.sh:167`: Worktree setup fetch now uses `${FORGE_REMOTE}`. Correct.\n- **info** `lib/formula-session.sh:89`: `resolve_forge_remote` falls back to `"origin"` when no forge host matches — no regression for standard setups.\n\nThe fix is minimal, complete, and matches the pattern already used in `supervisor`, `architect`, `gardener`, `planner`, and `predictor` scripts. ### Verdict **APPROVE** — Correctly resolves forge remote before first use; both hardcoded 'origin' git fetch calls replaced; fallback to 'origin' preserves backward compatibility --- *Reviewed at `b2be163` | [AGENTS.md](AGENTS.md)*

review-bot approved these changes 2026-04-06 12:17:39 +00:00

review-bot left a comment

Collaborator

AI Review: APPROVE — Correctly resolves forge remote before first use; both hardcoded 'origin' git fetch calls replaced; fallback to 'origin' preserves backward compatibility

AI Review: **APPROVE** — Correctly resolves forge remote before first use; both hardcoded 'origin' git fetch calls replaced; fallback to 'origin' preserves backward compatibility