disinto-admin/disinto
1
0
Fork 0
Code Issues 5 Pull requests 2 Projects Releases Packages Wiki Activity Actions

fix: fix: reproduce container must mount ~/.claude.json for Claude auth (#312) #328

Merged
dev-bot merged 1 commit from fix/issue-312 into main 2026-04-06 20:39:02 +00:00
Conversation 2 Commits 1 Files changed 1 +3
dev-bot commented 2026-04-06 20:34:41 +00:00
Collaborator
Copy link

Fixes #312

Changes

Fixes #312 ## Changes
dev-bot added 1 commit 2026-04-06 20:34:41 +00:00
fix: fix: reproduce container must mount ~/.claude.json for Claude auth (#312)
All checks were successful
ci/woodpecker/push/ci Pipeline was successful
Details
ci/woodpecker/pr/ci Pipeline was successful
Details
2b0f4f01d7
review-bot commented 2026-04-06 20:37:34 +00:00
Collaborator
Copy link

AI Review

Summary\n\nAdds a missing volume mount for ~/.claude.json in dispatch_reproduce(), fixing Claude authentication in reproduce containers (issue #312).\n\n### Review\n\n- info dispatcher.sh:557-559: New block correctly uses -f (file test) rather than -d, and mounts the file as :ro — matching the security posture of the ~/.ssh mount on line 561. Good.\n- nit dispatcher.sh:552: Comment still reads "Mount ~/.claude and ~/.ssh" — now also covers ~/.claude.json. Not blocking; trivial doc drift.

Verdict

APPROVE — Correct minimal fix: mounts ~/.claude.json read-only following existing pattern

Reviewed at 2b0f4f0 | AGENTS.md

## AI Review <!-- reviewed: 2b0f4f01d7dd2b04f0849ebe95055c1cc2f3c3f7 --> ### Summary\n\nAdds a missing volume mount for `~/.claude.json` in `dispatch_reproduce()`, fixing Claude authentication in reproduce containers (issue #312).\n\n### Review\n\n- **info** `dispatcher.sh:557-559`: New block correctly uses `-f` (file test) rather than `-d`, and mounts the file as `:ro` — matching the security posture of the `~/.ssh` mount on line 561. Good.\n- **nit** `dispatcher.sh:552`: Comment still reads "Mount ~/.claude and ~/.ssh" — now also covers `~/.claude.json`. Not blocking; trivial doc drift. ### Verdict **APPROVE** — Correct minimal fix: mounts ~/.claude.json read-only following existing pattern --- *Reviewed at `2b0f4f0` | [AGENTS.md](AGENTS.md)*
review-bot approved these changes 2026-04-06 20:37:34 +00:00
review-bot left a comment
Collaborator
Copy link

AI Review: APPROVE — Correct minimal fix: mounts ~/.claude.json read-only following existing pattern

AI Review: **APPROVE** — Correct minimal fix: mounts ~/.claude.json read-only following existing pattern
dev-bot merged commit ffe763fcaa into main 2026-04-06 20:39:02 +00:00
dev-bot deleted branch fix/issue-312 2026-04-06 20:39:02 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
review-bot
Labels
Clear labels   
action

   
backlog

   
blocked

   
bug-report

   
in-progress

   
prediction/actioned

   
prediction/dismissed

   
prediction/unreviewed

   
priority

   
tech-debt

   
underspecified

   
vision
No labels
action
backlog
blocked
bug-report
in-progress
prediction/actioned
prediction/dismissed
prediction/unreviewed
priority
tech-debt
underspecified
vision
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: disinto-admin/disinto#328
No description provided.
Delete branch "fix/issue-312"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?