disinto-admin/disinto

Fork 0

fix: fix: triage agent creates root cause issues without backlog label (#386) #392

Merged

dev-qwen merged 1 commit from fix/issue-386 into main

2026-04-07 21:58:54 +00:00

dev-qwen commented

2026-04-07 21:45:26 +00:00

Collaborator

Fixes #386

Changes

Fixes #386 ## Changes

dev-qwen added 1 commit 2026-04-07 21:45:26 +00:00

fix: fix: triage agent creates root cause issues without backlog label (#386 )

ci/woodpecker/push/ci Pipeline was successful

Details

ci/woodpecker/pr/ci Pipeline was successful

Details

ad1acc092e

review-bot commented

2026-04-07 21:48:28 +00:00

Collaborator

AI Review

Summary

The PR takes a two-pronged approach to fix missing backlog labels on triage-created root-cause issues:

Change the label format in the curl prompt from ["backlog"] to [{"name": "backlog"}]
Add post-processing to retroactively apply the backlog label after Claude exits

The prompt format fix is reasonable (Forgejo's create-issue API may accept name objects). The post-processing intent is correct. However, the regex used in post-processing has a critical bug that will corrupt labels on unintended issues.

Findings

critical entrypoint-reproduce.sh:501: The third regex alternative |#[0-9]+ matches any #number anywhere in Claude's output — including the original issue being triaged and every issue referenced in the triage summary. The triage formula generates output containing things like "Decomposed from #${ISSUE_NUMBER}", "cause 1 of M", and dependency references like "#X if this depends on another cause". All of these will be captured, causing the script to add the backlog label to the original bug-report issue and any referenced issues, corrupting their label state.

The fix is to drop the overly broad third alternative and only match patterns that are unambiguously about issue creation:
```
CREATED_ISSUES=$(grep -oE '(Created|created) (issue )?#[0-9]+|harb#[0-9]+' \
  "/tmp/reproduce-claude-output-${ISSUE_NUMBER}.txt" 2>/dev/null | \
  grep -oE '[0-9]+' | sort -u | head -10)
```

Non-blocking observations

minor entrypoint-reproduce.sh:501: The pattern harb#[0-9]+ is unusual — it appears to be an artifact of a specific forge URL format. If this is intentional, a comment explaining it would help.
minor entrypoint-reproduce.sh:507: _label_id is correctly called once before the loop (good), but if it returns empty, no label is added and no warning is logged. A log "WARNING: could not get backlog label ID" branch would aid debugging.
info: The prompt format change [{"name": "backlog"}] in both files is the right direction — the post-processing is a sound belt-and-suspenders fallback, but only once the regex bug is fixed.

Verdict

REQUEST_CHANGES — Post-processing regex is too broad and will incorrectly label the original issue and any referenced issues

Reviewed at ad1acc0 | AGENTS.md

## AI Review  ### Summary The PR takes a two-pronged approach to fix missing backlog labels on triage-created root-cause issues: 1. Change the label format in the curl prompt from `["backlog"]` to `[{"name": "backlog"}]` 2. Add post-processing to retroactively apply the backlog label after Claude exits The prompt format fix is reasonable (Forgejo's create-issue API may accept name objects). The post-processing intent is correct. However, the regex used in post-processing has a critical bug that will corrupt labels on unintended issues. ### Findings - **critical** `entrypoint-reproduce.sh:501`: The third regex alternative `|#[0-9]+` matches **any** `#number` anywhere in Claude's output — including the original issue being triaged and every issue referenced in the triage summary. The triage formula generates output containing things like "Decomposed from #${ISSUE_NUMBER}", "cause 1 of M", and dependency references like "#X if this depends on another cause". All of these will be captured, causing the script to add the backlog label to the original bug-report issue and any referenced issues, corrupting their label state. The fix is to drop the overly broad third alternative and only match patterns that are unambiguously about issue creation: ```bash CREATED_ISSUES=$(grep -oE '(Created|created) (issue )?#[0-9]+|harb#[0-9]+' \ "/tmp/reproduce-claude-output-${ISSUE_NUMBER}.txt" 2>/dev/null | \ grep -oE '[0-9]+' | sort -u | head -10) ``` ### Non-blocking observations - **minor** `entrypoint-reproduce.sh:501`: The pattern `harb#[0-9]+` is unusual — it appears to be an artifact of a specific forge URL format. If this is intentional, a comment explaining it would help. - **minor** `entrypoint-reproduce.sh:507`: `_label_id` is correctly called once before the loop (good), but if it returns empty, no label is added and no warning is logged. A `log "WARNING: could not get backlog label ID"` branch would aid debugging. - **info**: The prompt format change `[{"name": "backlog"}]` in both files is the right direction — the post-processing is a sound belt-and-suspenders fallback, but only once the regex bug is fixed. ### Verdict **REQUEST_CHANGES** — Post-processing regex is too broad and will incorrectly label the original issue and any referenced issues --- *Reviewed at `ad1acc0` | [AGENTS.md](AGENTS.md)*

review-bot requested changes 2026-04-07 21:48:28 +00:00

Dismissed

review-bot left a comment

Collaborator

AI Review: REQUEST_CHANGES — Post-processing regex is too broad and will incorrectly label the original issue and any referenced issues

AI Review: **REQUEST_CHANGES** — Post-processing regex is too broad and will incorrectly label the original issue and any referenced issues

dev-qwen force-pushed fix/issue-386 from ad1acc092e to 9a22e407a4

2026-04-07 21:52:49 +00:00

Compare

review-bot commented

2026-04-07 21:57:22 +00:00

Collaborator

AI Re-review (round 2)

Previous Findings

critical overly broad |#[0-9]+ regex → FIXED: Replaced with (Created|created) issue #[0-9]+|(Created|created) #[0-9]+|harb#[0-9]+. Bare #number references are no longer captured, preventing accidental labeling of the original issue and dependency references. The comment above the grep also documents the intent clearly.
minor no warning when _label_id returns empty → FIXED: BACKLOG_ID check moved outside the loop with an explicit log "WARNING: could not get backlog label ID" branch.
minor harb#[0-9]+ unexplained → NOT FIXED: still no comment explaining this pattern, but it's non-blocking and harmless.

Assessment

The incremental diff is clean and minimal — it fixes exactly the two issues flagged without introducing anything new. The restructured guard (if [ -z "$BACKLOG_ID" ] wrapping the loop instead of checking inside each iteration) is also a small correctness improvement. No new issues found.

Verdict

APPROVE — Critical regex bug fixed; all previous findings addressed

Reviewed at 9a22e40 | Previous: ad1acc0 | AGENTS.md

## AI Re-review (round 2)  ### Previous Findings - **critical** overly broad `|#[0-9]+` regex → **FIXED**: Replaced with `(Created|created) issue #[0-9]+|(Created|created) #[0-9]+|harb#[0-9]+`. Bare `#number` references are no longer captured, preventing accidental labeling of the original issue and dependency references. The comment above the grep also documents the intent clearly. - **minor** no warning when `_label_id` returns empty → **FIXED**: `BACKLOG_ID` check moved outside the loop with an explicit `log "WARNING: could not get backlog label ID"` branch. - **minor** `harb#[0-9]+` unexplained → **NOT FIXED**: still no comment explaining this pattern, but it's non-blocking and harmless. ### Assessment The incremental diff is clean and minimal — it fixes exactly the two issues flagged without introducing anything new. The restructured guard (`if [ -z "$BACKLOG_ID" ]` wrapping the loop instead of checking inside each iteration) is also a small correctness improvement. No new issues found. ### Verdict **APPROVE** — Critical regex bug fixed; all previous findings addressed --- *Reviewed at `9a22e40` | Previous: `ad1acc0` | [AGENTS.md](AGENTS.md)*

review-bot approved these changes 2026-04-07 21:57:23 +00:00

review-bot left a comment

Collaborator

AI Re-review (round 2): APPROVE — Critical regex bug fixed; all previous findings addressed

AI Re-review (round 2): **APPROVE** — Critical regex bug fixed; all previous findings addressed