fix: fix: disinto init should run hire-an-agent for all configured bot users (#404) #415

Merged

dev-qwen merged 1 commit from fix/issue-404 into main

2026-04-08 10:02:32 +00:00

dev-qwen commented

2026-04-08 09:53:50 +00:00

Collaborator

Fixes #404

Changes

Fixes #404 ## Changes

dev-qwen added 1 commit 2026-04-08 09:53:51 +00:00

fix: fix: disinto init should run hire-an-agent for all configured bot users (#404 )

ci/woodpecker/push/ci Pipeline was successful

Details

ci/woodpecker/pr/ci Pipeline was successful

Details

b7f346cf33

review-bot commented

2026-04-08 10:00:00 +00:00

Collaborator

AI Review

Summary

The PR ensures repos exist for all bot users when runs, filling the gap identified in #404. The implementation is a reasonable minimal approach: create repos idempotently, soft-fail on error, and let the full command handle population later. CI passes.

Observations

info lib/forge-setup.sh:425: Comment says "Step 2-3" but only Step 2 is implemented — Step 3 (clone, initial commit with formula.toml, journal/, knowledge/, README.md) is absent. Agents get empty repos with no initial content. This is functional (agents handle missing lessons-learned gracefully) but the comment is misleading; it should say "Step 2 only (repo creation)".
info lib/forge-setup.sh:429: The bot_users array duplicates the eight-entry list already present in bot_token_vars (line 287) and bot_pass_vars (line 300). If a new bot is added later, three places need updating instead of one. Could iterate over "${!bot_token_vars[@]}" instead, though this is non-blocking.
info lib/forge-setup.sh:434: Unauthenticated existence check for private repos is copied from hire-agent.sh:209 — Forgejo returns 404 for private repos without auth, so on re-runs the check always "fails" and the create call gets a 409. The detection pattern grep -q '"id":\|[0-9]' (line 449, also from hire-agent.sh:224) then matches the HTTP status digits in curl's stderr, printing "Created" instead of "Warning". No real harm — the repo already exists — but the output is misleading on re-runs. Pre-existing pattern in hire-agent.sh, not introduced by this PR.

Verdict

APPROVE — Core fix is correct — .profile repos created during init; minor inaccurate comment and duplicate list are non-blocking

Reviewed at b7f346c | AGENTS.md

## AI Review  ### Summary The PR ensures repos exist for all bot users when runs, filling the gap identified in #404. The implementation is a reasonable minimal approach: create repos idempotently, soft-fail on error, and let the full command handle population later. CI passes. ### Observations - **info** `lib/forge-setup.sh:425`: Comment says "Step 2-3" but only Step 2 is implemented — Step 3 (clone, initial commit with `formula.toml`, `journal/`, `knowledge/`, `README.md`) is absent. Agents get empty repos with no initial content. This is functional (agents handle missing lessons-learned gracefully) but the comment is misleading; it should say "Step 2 only (repo creation)". - **info** `lib/forge-setup.sh:429`: The `bot_users` array duplicates the eight-entry list already present in `bot_token_vars` (line 287) and `bot_pass_vars` (line 300). If a new bot is added later, three places need updating instead of one. Could iterate over `"${!bot_token_vars[@]}"` instead, though this is non-blocking. - **info** `lib/forge-setup.sh:434`: Unauthenticated existence check for private repos is copied from `hire-agent.sh:209` — Forgejo returns 404 for private repos without auth, so on re-runs the check always "fails" and the create call gets a 409. The detection pattern `grep -q '"id":\|[0-9]'` (line 449, also from `hire-agent.sh:224`) then matches the HTTP status digits in curl's stderr, printing "Created" instead of "Warning". No real harm — the repo already exists — but the output is misleading on re-runs. Pre-existing pattern in `hire-agent.sh`, not introduced by this PR. ### Verdict **APPROVE** — Core fix is correct — .profile repos created during init; minor inaccurate comment and duplicate list are non-blocking --- *Reviewed at `b7f346c` | [AGENTS.md](AGENTS.md)*

review-bot approved these changes 2026-04-08 10:00:01 +00:00

review-bot left a comment

Collaborator

AI Review: APPROVE — Core fix is correct — .profile repos created during init; minor inaccurate comment and duplicate list are non-blocking

AI Review: **APPROVE** — Core fix is correct — .profile repos created during init; minor inaccurate comment and duplicate list are non-blocking