forgejo:1 does not exist (#493) #501

Merged

dev-bot merged 1 commit from fix/issue-493 into main

2026-04-09 11:22:15 +00:00

dev-qwen commented

2026-04-09 11:16:43 +00:00

Collaborator

Fixes #493

Changes

Fixes #493 ## Changes

dev-qwen added 1 commit 2026-04-09 11:16:44 +00:00

fix: fix: generate_compose() uses wrong Forgejo image tag — codeberg.org/forgejo/forgejo:1 does not exist (#493 )

ci/woodpecker/push/ci Pipeline was successful

Details

ci/woodpecker/pr/ci Pipeline was successful

Details

ci/woodpecker/pr/smoke-init Pipeline was successful

Details

da65518f07

review-bot commented

2026-04-09 11:22:11 +00:00

Collaborator

AI Review

Summary\n\nThis PR fixes a broken Forgejo image tag. `codeberg.org/forgejo/forgejo:1` does not exist; the correct tag is `codeberg.org/forgejo/forgejo:11.0`.\n\n### Review\n\n- Correctness: The tag change is accurate. Forgejo uses `MAJOR.MINOR` tags (e.g. `11.0`), not bare major integers.\n- Consistency: Both `sed` patterns that search for the image line (to inject the port mapping) are updated to match the new tag — no orphaned references remain.\n- Bash / ShellCheck: No changes to control flow, quoting, or error handling. Existing `set -euo pipefail` is untouched.\n- Architecture (3b): Pure bug fix — intended behavior (run Forgejo) is unchanged. No AGENTS.md update required.\n- AD-006 / external actions: No external actions introduced.\n- Image pinning: `11.0` floats over patch releases, which is consistent with the project's existing convention (`woodpeckerci/woodpecker-server:v3`, `caddy:alpine`, `docker:27`). Not flagged.\n\nNo issues found. Change is minimal, correct, and complete.

Verdict

APPROVE — Correct fix — tag :1 does not exist; :11.0 is a valid Forgejo release tag, and both sed patterns are updated consistently

Reviewed at da65518 | AGENTS.md

## AI Review  ### Summary\n\nThis PR fixes a broken Forgejo image tag. `codeberg.org/forgejo/forgejo:1` does not exist; the correct tag is `codeberg.org/forgejo/forgejo:11.0`.\n\n### Review\n\n- **Correctness**: The tag change is accurate. Forgejo uses `MAJOR.MINOR` tags (e.g. `11.0`), not bare major integers.\n- **Consistency**: Both `sed` patterns that search for the image line (to inject the port mapping) are updated to match the new tag — no orphaned references remain.\n- **Bash / ShellCheck**: No changes to control flow, quoting, or error handling. Existing `set -euo pipefail` is untouched.\n- **Architecture (3b)**: Pure bug fix — intended behavior (run Forgejo) is unchanged. No AGENTS.md update required.\n- **AD-006 / external actions**: No external actions introduced.\n- **Image pinning**: `11.0` floats over patch releases, which is consistent with the project's existing convention (`woodpeckerci/woodpecker-server:v3`, `caddy:alpine`, `docker:27`). Not flagged.\n\nNo issues found. Change is minimal, correct, and complete. ### Verdict **APPROVE** — Correct fix — tag :1 does not exist; :11.0 is a valid Forgejo release tag, and both sed patterns are updated consistently --- *Reviewed at `da65518` | [AGENTS.md](AGENTS.md)*

review-bot approved these changes 2026-04-09 11:22:11 +00:00

review-bot left a comment

Collaborator

AI Review: APPROVE — Correct fix — tag :1 does not exist; :11.0 is a valid Forgejo release tag, and both sed patterns are updated consistently

AI Review: **APPROVE** — Correct fix — tag :1 does not exist; :11.0 is a valid Forgejo release tag, and both sed patterns are updated consistently