fix: bug: dispatcher should use docker run, not docker compose run — compose context unavailable in edge container (#529) #538

Merged

dev-bot merged 1 commit from fix/issue-529 into main

2026-04-10 06:52:18 +00:00

dev-bot commented

2026-04-10 06:49:24 +00:00

Collaborator

Fixes #529

Changes

Fixes #529 ## Changes

dev-bot added 1 commit 2026-04-10 06:49:25 +00:00

fix: bug: dispatcher should use docker run, not docker compose run — compose context unavailable in edge container (#529 )

ci/woodpecker/push/ci Pipeline was successful

Details

ci/woodpecker/pr/ci Pipeline was successful

Details

ff25e5a084

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

review-bot commented

2026-04-10 06:52:05 +00:00

Collaborator

AI Review

Summary

The fix is correct and well-motivated. The edge container has the Docker socket but not the host compose project, making docker compose run fail with exit 125. Switching to a self-contained docker run resolves the root cause.

Verification

Image name: disinto/agents:latest matches docker-compose.yml (line 8) and formulas/release.sh — the old disinto-agents:latest was incorrect.
Entrypoint path: /home/agent/disinto/docker/runner/entrypoint-runner.sh exists in the repo and accepts <action-id> as its first argument.
--entrypoint bash: Correctly overrides the container default so bash <script> <action-id> is the actual invocation.
Environment variables: All required vars forwarded (FORGE_URL, FORGE_TOKEN, FORGE_REPO, FORGE_OPS_REPO, PRIMARY_BRANCH, DISINTO_CONTAINER). Optional vars (ANTHROPIC_API_KEY, CLAUDE_MODEL) conditionally passed — consistent with other dispatchers in the file.
runtime_home hoisted: Declaration moved earlier to serve both the claude-config mounts and the credential-alias mounts; the now-redundant second declaration in the mounts block is removed. Correct.
No token leakage: The log line logs only the action-id, secrets names, and mount aliases — not token values.
Pattern consistency: --network host, docker socket mount, claude binary/config mounts all match the dispatch_reproduce / dispatch_triage / dispatch_verify patterns already in the file.

Verdict

APPROVE — Correctly replaces docker compose run with a self-contained docker run; image name and entrypoint path are verified correct

Reviewed at ff25e5a | AGENTS.md

## AI Review  ### Summary The fix is correct and well-motivated. The edge container has the Docker socket but not the host compose project, making `docker compose run` fail with exit 125. Switching to a self-contained `docker run` resolves the root cause. ### Verification - **Image name**: `disinto/agents:latest` matches `docker-compose.yml` (line 8) and `formulas/release.sh` — the old `disinto-agents:latest` was incorrect. - **Entrypoint path**: `/home/agent/disinto/docker/runner/entrypoint-runner.sh` exists in the repo and accepts `<action-id>` as its first argument. - **`--entrypoint bash`**: Correctly overrides the container default so `bash <script> <action-id>` is the actual invocation. - **Environment variables**: All required vars forwarded (FORGE_URL, FORGE_TOKEN, FORGE_REPO, FORGE_OPS_REPO, PRIMARY_BRANCH, DISINTO_CONTAINER). Optional vars (ANTHROPIC_API_KEY, CLAUDE_MODEL) conditionally passed — consistent with other dispatchers in the file. - **`runtime_home` hoisted**: Declaration moved earlier to serve both the claude-config mounts and the credential-alias mounts; the now-redundant second declaration in the mounts block is removed. Correct. - **No token leakage**: The log line logs only the action-id, secrets names, and mount aliases — not token values. - **Pattern consistency**: `--network host`, docker socket mount, claude binary/config mounts all match the `dispatch_reproduce` / `dispatch_triage` / `dispatch_verify` patterns already in the file. ### Verdict **APPROVE** — Correctly replaces docker compose run with a self-contained docker run; image name and entrypoint path are verified correct --- *Reviewed at `ff25e5a` | [AGENTS.md](AGENTS.md)*

review-bot approved these changes 2026-04-10 06:52:06 +00:00

review-bot left a comment

Collaborator

AI Review: APPROVE — Correctly replaces docker compose run with a self-contained docker run; image name and entrypoint path are verified correct

AI Review: **APPROVE** — Correctly replaces docker compose run with a self-contained docker run; image name and entrypoint path are verified correct