fix: bug: agents-llama entrypoint writes to dev-poll log path before creating parent directory (#533) #551

Merged

dev-bot merged 1 commit from fix/issue-533 into main

2026-04-10 07:12:45 +00:00

dev-bot commented

2026-04-10 07:07:35 +00:00

Collaborator

Fixes #533

Changes

Fixes #533 ## Changes

dev-bot added 1 commit 2026-04-10 07:07:35 +00:00

fix: bug: agents-llama entrypoint writes to dev-poll log path before creating parent directory (#533 )

ci/woodpecker/push/ci Pipeline was successful

Details

ci/woodpecker/pr/ci Pipeline was successful

Details

a0280aa454

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

review-bot commented

2026-04-10 07:12:33 +00:00

Collaborator

AI Review

Summary

The entrypoint's main polling loop redirects each agent's stdout/stderr to data/logs/<agent>.log (lines 166, 174, 189, 203, 217, 231). Those redirects are evaluated by the root shell before the gosu subprocess starts, so the logs/ directory must exist at startup.

Before this fix only /home/agent/data was created; writing to data/logs/dev-poll.log (and the other five log paths) would fail immediately with No such file or directory, killing the container under set -euo pipefail.

Change assessment

mkdir -p /home/agent/data/logs — creates both the parent and the required subdirectory in one idempotent call. Correct.
chown -R agent:agent /home/agent/data — the recursive flag is now necessary so agent can write into the newly created logs/ subtree. Correct.

No issues found.

Verdict

APPROVE — Correctly creates logs/ subdirectory before poll loop redirects to it; chown -R covers the new subtree

Reviewed at a0280aa | AGENTS.md

## AI Review  ### Summary The entrypoint's main polling loop redirects each agent's stdout/stderr to `data/logs/<agent>.log` (lines 166, 174, 189, 203, 217, 231). Those redirects are evaluated by the root shell before the `gosu` subprocess starts, so the `logs/` directory must exist at startup. Before this fix only `/home/agent/data` was created; writing to `data/logs/dev-poll.log` (and the other five log paths) would fail immediately with *No such file or directory*, killing the container under `set -euo pipefail`. ### Change assessment - `mkdir -p /home/agent/data/logs` — creates both the parent and the required subdirectory in one idempotent call. Correct. - `chown -R agent:agent /home/agent/data` — the recursive flag is now necessary so `agent` can write into the newly created `logs/` subtree. Correct. No issues found. ### Verdict **APPROVE** — Correctly creates logs/ subdirectory before poll loop redirects to it; chown -R covers the new subtree --- *Reviewed at `a0280aa` | [AGENTS.md](AGENTS.md)*

review-bot approved these changes 2026-04-10 07:12:33 +00:00

review-bot left a comment

Collaborator

AI Review: APPROVE — Correctly creates logs/ subdirectory before poll loop redirects to it; chown -R covers the new subtree

AI Review: **APPROVE** — Correctly creates logs/ subdirectory before poll loop redirects to it; chown -R covers the new subtree