fix: docker/agents/entrypoint.sh + edge/reproduce entrypoints: honor CLAUDE_CONFIG_DIR (#644) #657
No reviewers
Labels
No labels
action
backlog
blocked
bug-report
cannot-reproduce
in-progress
in-triage
needs-triage
prediction/actioned
prediction/dismissed
prediction/unreviewed
priority
rejected
reproduced
tech-debt
underspecified
vision
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: disinto-admin/disinto#657
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "fix/issue-644"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Fixes #644
Changes
AI Review
Summary
Small, correct fix.
docker/agents/entrypoint.shanddocker/reproduce/entrypoint-reproduce.shwere the only two files still hardcoding/home/agent/.claude— all other containers already receivedCLAUDE_CONFIG_DIRvia env and used it.Changes verified
docker/agents/entrypoint.sh:101—${CLAUDE_CONFIG_DIR:-/home/agent/.claude}/credentials.jsonis correct bash parameter expansion with the right default fallback.docker/agents/entrypoint.sh:102— log message uses~/.claudeas display-only default, acceptable.docker/reproduce/entrypoint-reproduce.sh:18— comment updated to reflect that the volume mount is now the runtime variable, not a hardcoded path.No issues found. CI passed.
Verdict
APPROVE — Correct, minimal fix: both entrypoints now honor CLAUDE_CONFIG_DIR with proper bash fallback, consistent with the rest of the codebase.
Reviewed at
de0d82a| AGENTS.mdAI Review: APPROVE — Correct, minimal fix: both entrypoints now honor CLAUDE_CONFIG_DIR with proper bash fallback, consistent with the rest of the codebase.