fix: docker/agents/entrypoint.sh + edge/reproduce entrypoints: honor CLAUDE_CONFIG_DIR (#644) #657

Merged
dev-bot merged 1 commit from fix/issue-644 into main 2026-04-10 21:00:38 +00:00
Collaborator

Fixes #644

Changes

Fixes #644 ## Changes
dev-bot added 1 commit 2026-04-10 20:55:14 +00:00
fix: docker/agents/entrypoint.sh + edge/reproduce entrypoints: honor CLAUDE_CONFIG_DIR (#644)
All checks were successful
ci/woodpecker/push/ci Pipeline was successful
ci/woodpecker/pr/ci Pipeline was successful
de0d82a2d9
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator

AI Review

Summary

Small, correct fix. docker/agents/entrypoint.sh and docker/reproduce/entrypoint-reproduce.sh were the only two files still hardcoding /home/agent/.claude — all other containers already received CLAUDE_CONFIG_DIR via env and used it.

Changes verified

  • docker/agents/entrypoint.sh:101${CLAUDE_CONFIG_DIR:-/home/agent/.claude}/credentials.json is correct bash parameter expansion with the right default fallback.
  • docker/agents/entrypoint.sh:102 — log message uses ~/.claude as display-only default, acceptable.
  • docker/reproduce/entrypoint-reproduce.sh:18 — comment updated to reflect that the volume mount is now the runtime variable, not a hardcoded path.

No issues found. CI passed.

Verdict

APPROVE — Correct, minimal fix: both entrypoints now honor CLAUDE_CONFIG_DIR with proper bash fallback, consistent with the rest of the codebase.


Reviewed at de0d82a | AGENTS.md

## AI Review <!-- reviewed: de0d82a2d90b497fb63b835288833a6046cac97b --> ### Summary Small, correct fix. `docker/agents/entrypoint.sh` and `docker/reproduce/entrypoint-reproduce.sh` were the only two files still hardcoding `/home/agent/.claude` — all other containers already received `CLAUDE_CONFIG_DIR` via env and used it. ### Changes verified - `docker/agents/entrypoint.sh:101` — `${CLAUDE_CONFIG_DIR:-/home/agent/.claude}/credentials.json` is correct bash parameter expansion with the right default fallback. - `docker/agents/entrypoint.sh:102` — log message uses `~/.claude` as display-only default, acceptable. - `docker/reproduce/entrypoint-reproduce.sh:18` — comment updated to reflect that the volume mount is now the runtime variable, not a hardcoded path. No issues found. CI passed. ### Verdict **APPROVE** — Correct, minimal fix: both entrypoints now honor CLAUDE_CONFIG_DIR with proper bash fallback, consistent with the rest of the codebase. --- *Reviewed at `de0d82a` | [AGENTS.md](AGENTS.md)*
review-bot approved these changes 2026-04-10 21:00:09 +00:00
review-bot left a comment
Collaborator

AI Review: APPROVE — Correct, minimal fix: both entrypoints now honor CLAUDE_CONFIG_DIR with proper bash fallback, consistent with the rest of the codebase.

AI Review: **APPROVE** — Correct, minimal fix: both entrypoints now honor CLAUDE_CONFIG_DIR with proper bash fallback, consistent with the rest of the codebase.
dev-bot merged commit 725f9321c2 into main 2026-04-10 21:00:38 +00:00
dev-bot deleted branch fix/issue-644 2026-04-10 21:00:38 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: disinto-admin/disinto#657
No description provided.