fix: .env.example: document CLAUDE_SHARED_DIR / CLAUDE_CONFIG_DIR (#645) #658

Merged

dev-qwen merged 1 commit from fix/issue-645 into main

2026-04-10 21:09:26 +00:00

dev-qwen commented

2026-04-10 21:04:53 +00:00

Collaborator

Fixes #645

Changes

Fixes #645 ## Changes

dev-qwen added 1 commit 2026-04-10 21:04:54 +00:00

fix: .env.example: document CLAUDE_SHARED_DIR / CLAUDE_CONFIG_DIR (#645 )

ci/woodpecker/push/ci Pipeline was successful

Details

ci/woodpecker/pr/ci Pipeline was successful

Details

0553654cb1

review-bot commented

2026-04-10 21:08:32 +00:00

Collaborator

AI Review

Summary\n\nThis PR rewrites the comment block for `CLAUDE_SHARED_DIR` / `CLAUDE_CONFIG_DIR` in `.env.example`. The new prose is strictly better: it explains why the path must be outside `$HOME` (UID mapping in Docker bind mounts), adds the absolute-path-parity constraint, and points readers to `docs/CLAUDE-AUTH-CONCURRENCY.md` — which exists and is the right place for deeper detail.\n\n### Checklist\n\n- Accuracy: The new comment correctly describes the OAuth lock mechanism and the UID-mapping rationale. No false claims detected.\n- Doc reference: `docs/CLAUDE-AUTH-CONCURRENCY.md` exists in the repo.\n- Issue cross-references: The old comment cited #641 and #642; the new one drops inline issue refs in favour of the doc file. Acceptable — the doc is the durable reference.\n- `[CONFIG]` tags: The two variable lines previously carried inline `# [CONFIG]` tags consistent with the rest of the file. This PR removes them. The convention is defined at the top of the file ("Variables marked [CONFIG] are non-sensitive and safe in plaintext") and every other non-secret variable retains the tag. The omission is a minor style regression but is not harmful — the surrounding prose makes the non-secret nature clear. Not worth blocking.\n- Security / secrets: No secret exposure; both vars are config-only paths.\n- Structural impact: No code or infra changed; structural analysis shows no affected objectives.

Verdict

APPROVE — Documentation-only improvement with accurate, more informative comments and a valid doc reference

Reviewed at 0553654 | AGENTS.md

## AI Review  ### Summary\n\nThis PR rewrites the comment block for `CLAUDE_SHARED_DIR` / `CLAUDE_CONFIG_DIR` in `.env.example`. The new prose is strictly better: it explains *why* the path must be outside `$HOME` (UID mapping in Docker bind mounts), adds the absolute-path-parity constraint, and points readers to `docs/CLAUDE-AUTH-CONCURRENCY.md` — which exists and is the right place for deeper detail.\n\n### Checklist\n\n- **Accuracy**: The new comment correctly describes the OAuth lock mechanism and the UID-mapping rationale. No false claims detected.\n- **Doc reference**: `docs/CLAUDE-AUTH-CONCURRENCY.md` exists in the repo.\n- **Issue cross-references**: The old comment cited #641 and #642; the new one drops inline issue refs in favour of the doc file. Acceptable — the doc is the durable reference.\n- **`[CONFIG]` tags**: The two variable lines previously carried inline `# [CONFIG]` tags consistent with the rest of the file. This PR removes them. The convention is defined at the top of the file (*"Variables marked [CONFIG] are non-sensitive and safe in plaintext"*) and every other non-secret variable retains the tag. The omission is a minor style regression but is not harmful — the surrounding prose makes the non-secret nature clear. Not worth blocking.\n- **Security / secrets**: No secret exposure; both vars are config-only paths.\n- **Structural impact**: No code or infra changed; structural analysis shows no affected objectives. ### Verdict **APPROVE** — Documentation-only improvement with accurate, more informative comments and a valid doc reference --- *Reviewed at `0553654` | [AGENTS.md](AGENTS.md)*

review-bot approved these changes 2026-04-10 21:08:33 +00:00

review-bot left a comment

Collaborator

AI Review: APPROVE — Documentation-only improvement with accurate, more informative comments and a valid doc reference

AI Review: **APPROVE** — Documentation-only improvement with accurate, more informative comments and a valid doc reference