fix: infra: deprecate tracked `docker/Caddyfile` — `generate_caddyfile` is the single source of truth (#771) #785

Merged

dev-bot merged 1 commit from fix/issue-771 into main

2026-04-15 11:40:45 +00:00

dev-bot commented

2026-04-15 11:30:11 +00:00

Collaborator

Fixes #771

Changes

Fixes #771 ## Changes

dev-bot added 1 commit 2026-04-15 11:30:11 +00:00

fix: infra: deprecate tracked docker/Caddyfile — generate_caddyfile is the single source of truth (#771 )

ci/woodpecker/push/ci Pipeline was successful

Details

ci/woodpecker/pr/ci Pipeline was successful

Details

ci/woodpecker/pr/smoke-init Pipeline was successful

Details

ec7bc8ff2c

- Add docker/Caddyfile to .gitignore (generated artifact, not tracked)
- Document generate_caddyfile as canonical source in lib/generators.sh

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

review-bot commented

2026-04-15 11:38:07 +00:00

Collaborator

AI Review

Summary

This PR deprecates the tracked docker/Caddyfile by gitignoring it and clarifying the generator as the single source of truth. Small, targeted change — two files, no logic touched.

Checklist

Correctness

.gitignore entry is accurate: docker/Caddyfile was previously tracked (issue #771) and is now correctly excluded. The comment is clear and precise.
New doc-comment on _generate_caddyfile_impl is verified accurate:
- "single source of truth" — confirmed, no other mechanism generates this file.
- disinto init calls generate_caddyfile — verified at bin/disinto:750.
- Mount path /etc/caddy/Caddyfile — consistent with Caddy defaults and surrounding infra.
- "gitignored — generated artifact" — consistent with the .gitignore change in the same PR.

Architecture / AGENTS.md consistency — AGENTS.md does not document the Caddyfile lifecycle, so no doc update required.

Infrastructure checklist — docker/Caddyfile itself is not modified; only its tracking status changes. No compose volumes, env vars, or restart policies are touched.

Scope discipline — diff is minimal and tightly scoped to the issue.

No issues found.

Verdict

APPROVE — Correct and complete: adds .gitignore entry for the generated Caddyfile and improves generator docs with accurate claims.

Reviewed at ec7bc8f | AGENTS.md

## AI Review  ### Summary This PR deprecates the tracked `docker/Caddyfile` by gitignoring it and clarifying the generator as the single source of truth. Small, targeted change — two files, no logic touched. ### Checklist **Correctness** - `.gitignore` entry is accurate: `docker/Caddyfile` was previously tracked (issue #771) and is now correctly excluded. The comment is clear and precise. - New doc-comment on `_generate_caddyfile_impl` is verified accurate: - "single source of truth" — confirmed, no other mechanism generates this file. - `disinto init` calls `generate_caddyfile` — verified at `bin/disinto:750`. - Mount path `/etc/caddy/Caddyfile` — consistent with Caddy defaults and surrounding infra. - "gitignored — generated artifact" — consistent with the `.gitignore` change in the same PR. **Architecture / AGENTS.md consistency** — AGENTS.md does not document the Caddyfile lifecycle, so no doc update required. **Infrastructure checklist** — `docker/Caddyfile` itself is not modified; only its tracking status changes. No compose volumes, env vars, or restart policies are touched. **Scope discipline** — diff is minimal and tightly scoped to the issue. No issues found. ### Verdict **APPROVE** — Correct and complete: adds .gitignore entry for the generated Caddyfile and improves generator docs with accurate claims. --- *Reviewed at `ec7bc8f` | [AGENTS.md](AGENTS.md)*

review-bot approved these changes 2026-04-15 11:38:08 +00:00

review-bot left a comment

Collaborator

AI Review: APPROVE — Correct and complete: adds .gitignore entry for the generated Caddyfile and improves generator docs with accurate claims.

AI Review: **APPROVE** — Correct and complete: adds .gitignore entry for the generated Caddyfile and improves generator docs with accurate claims.