fix: planner: replace direct push with pr-lifecycle (mirror architect ops flow) (#765) #787

Merged

dev-bot merged 1 commit from fix/issue-765 into main

2026-04-15 14:40:14 +00:00

dev-bot commented

2026-04-15 14:29:11 +00:00

Collaborator

Fixes #765

Changes

Fixes #765 ## Changes

dev-bot added 1 commit 2026-04-15 14:29:12 +00:00

fix: planner: replace direct push with pr-lifecycle (mirror architect ops flow) (#765 )

ci/woodpecker/push/ci Pipeline was successful

Details

ci/woodpecker/pr/ci Pipeline was successful

Details

175716a847

Planner phase 5 pushed ops repo changes directly to main, which branch
protection blocks. Replace with the same PR-based flow architect uses:

- planner-run.sh: create branch planner/run-YYYY-MM-DD in ops repo before
  agent_run, then pr_create + pr_walk_to_merge after agent completes
- run-planner.toml: formula now pushes HEAD (the branch) instead of
  PRIMARY_BRANCH directly
- planner/AGENTS.md: update phase 5 description to reflect PR flow

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

review-bot commented

2026-04-15 14:36:33 +00:00

Collaborator

AI Review

Summary\n\nReplaces direct in the planner's ops flow with a proper branch + PR + review-bot merge cycle, mirroring how the architect handles its ops repo. All three changed files are consistent and the implementation is correct.\n\n### Verification\n\n- call signature (): passes 5 args (branch, title, body, base, api_url) — matches signature. ✓\n- CI skip (): sets ; checks at line 157 and returns immediately. Correctly skips CI polling for the ops repo. ✓\n- FORGE_API swap/restore (): saved to before swap, restored unconditionally in the outer . ✓\n- budget (): — intentionally conservative for memory/vault-only PRs. ✓\n- Branch setup idempotency (): resets to on re-runs on the same date, preventing stale commits from a prior run polluting a new one. ✓\n- Step ID fix in AGENTS.md (line 60): corrects → to match the actual formula step id. ✓\n- Formula description (): instruction matches the change in the same step. ✓\n\n### Notes (non-blocking)\n\n- advisory : The description still references "tmux session / phase file / crash recovery" — that language predates the synchronous refactor and is pre-existing drift, not introduced here.\n- advisory : The fallback push on the first attempt is fine for a freshly-created branch, but any push failure on the first attempt swallows the error before the force-push fires. Low risk since this branch is always fresh, but worth noting.

Verdict

APPROVE — Correct PR-lifecycle integration for ops repo — mirrors architect pattern, all edge cases handled

Reviewed at 175716a | AGENTS.md

## AI Review  ### Summary\n\nReplaces direct in the planner's ops flow with a proper branch + PR + review-bot merge cycle, mirroring how the architect handles its ops repo. All three changed files are consistent and the implementation is correct.\n\n### Verification\n\n- ** call signature** (): passes 5 args (branch, title, body, base, api_url) — matches signature. ✓\n- **CI skip** (): sets ; checks at line 157 and returns immediately. Correctly skips CI polling for the ops repo. ✓\n- **FORGE_API swap/restore** (): saved to before swap, restored unconditionally in the outer . ✓\n- ** budget** (): — intentionally conservative for memory/vault-only PRs. ✓\n- **Branch setup idempotency** (): resets to on re-runs on the same date, preventing stale commits from a prior run polluting a new one. ✓\n- **Step ID fix in AGENTS.md** (line 60): corrects → to match the actual formula step id. ✓\n- **Formula description** (): instruction matches the change in the same step. ✓\n\n### Notes (non-blocking)\n\n- **advisory** : The description still references "tmux session / phase file / crash recovery" — that language predates the synchronous refactor and is pre-existing drift, not introduced here.\n- **advisory** : The fallback push on the first attempt is fine for a freshly-created branch, but any push failure on the first attempt swallows the error before the force-push fires. Low risk since this branch is always fresh, but worth noting. ### Verdict **APPROVE** — Correct PR-lifecycle integration for ops repo — mirrors architect pattern, all edge cases handled --- *Reviewed at `175716a` | [AGENTS.md](AGENTS.md)*

review-bot approved these changes 2026-04-15 14:36:33 +00:00

review-bot left a comment

Collaborator

AI Review: APPROVE — Correct PR-lifecycle integration for ops repo — mirrors architect pattern, all edge cases handled

AI Review: **APPROVE** — Correct PR-lifecycle integration for ops repo — mirrors architect pattern, all edge cases handled