to action-vault namespace (#792) #804

Merged

dev-bot merged 1 commit from fix/issue-792 into main

2026-04-15 18:22:49 +00:00

dev-bot commented

2026-04-15 18:16:45 +00:00

Collaborator

Fixes #792

Changes

Fixes #792 ## Changes

dev-bot added 1 commit 2026-04-15 18:16:46 +00:00

fix: [nomad-prep] P0 — rename lib/vault.sh + vault/ to action-vault namespace (#792 )

ci/woodpecker/push/ci Pipeline was successful

Details

ci/woodpecker/pr/ci Pipeline was successful

Details

e9a018db5c

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

review-bot commented

2026-04-15 18:21:42 +00:00

Collaborator

AI Review

Summary

Pure namespace rename: lib/vault.sh → lib/action-vault.sh and vault/ → action-vault/. All callers, docs, and formulas updated.

Findings

low action-vault/validate.sh:2,4,7,26: Internal comments still reference vault/validate.sh, vault/SCHEMA.md, and vault/examples/publish.toml. File was renamed with 100% similarity so content wasn't touched. Comments only — no runtime impact, but mildly misleading.
low action-vault/SCHEMA.md:90: Usage example shows ./vault/validate.sh vault/actions/... — both the script path and the argument path are stale after the rename. Anyone copy-pasting this won't find the file at that path.

These are cosmetic gaps from the 100%-similarity renames; no functional correctness issues found. All runtime source paths in lib/action-vault.sh (lines 136, 164) and lib/release.sh (line 22) are correctly updated.

Verdict

APPROVE — Complete, correct rename — all runtime paths updated; stale comments in 100%-similarity-renamed files are cosmetic only

Reviewed at e9a018d | AGENTS.md

## AI Review  ### Summary Pure namespace rename: `lib/vault.sh` → `lib/action-vault.sh` and `vault/` → `action-vault/`. All callers, docs, and formulas updated. ### Findings - **low** `action-vault/validate.sh:2,4,7,26`: Internal comments still reference `vault/validate.sh`, `vault/SCHEMA.md`, and `vault/examples/publish.toml`. File was renamed with 100% similarity so content wasn't touched. Comments only — no runtime impact, but mildly misleading. - **low** `action-vault/SCHEMA.md:90`: Usage example shows `./vault/validate.sh vault/actions/...` — both the script path and the argument path are stale after the rename. Anyone copy-pasting this won't find the file at that path. These are cosmetic gaps from the 100%-similarity renames; no functional correctness issues found. All runtime `source` paths in `lib/action-vault.sh` (lines 136, 164) and `lib/release.sh` (line 22) are correctly updated. ### Verdict **APPROVE** — Complete, correct rename — all runtime paths updated; stale comments in 100%-similarity-renamed files are cosmetic only --- *Reviewed at `e9a018d` | [AGENTS.md](AGENTS.md)*

review-bot approved these changes 2026-04-15 18:21:42 +00:00

review-bot left a comment

Collaborator

AI Review: APPROVE — Complete, correct rename — all runtime paths updated; stale comments in 100%-similarity-renamed files are cosmetic only

AI Review: **APPROVE** — Complete, correct rename — all runtime paths updated; stale comments in 100%-similarity-renamed files are cosmetic only