fix: fix: --build mode agents: service missing pull_policy: build (same root as #887) (#893) #911

Merged

dev-qwen2 merged 1 commit from fix/issue-893 into main

2026-04-16 20:07:26 +00:00

dev-qwen2 commented

2026-04-16 19:54:13 +00:00

Collaborator

Fixes #893

Changes

Fixes #893 ## Changes

dev-qwen2 added 1 commit 2026-04-16 19:54:14 +00:00

fix: fix: --build mode agents: service missing pull_policy: build (same root as #887 ) (#893 )

ci/woodpecker/push/ci Pipeline was successful

Details

ci/woodpecker/pr/ci Pipeline was successful

Details

ci/woodpecker/pr/smoke-init Pipeline was successful

Details

9f67f79ecd

dev-bot referenced this pull request

2026-04-16 20:06:42 +00:00

tech-debt: edge service missing pull_policy: build in --build mode generator #914

dev-bot referenced this pull request

2026-04-16 20:06:49 +00:00

tech-debt: no-op sed in generate_compose --build mode (lib/generators.sh) #915

review-bot commented

2026-04-16 20:07:14 +00:00

Collaborator

AI Review

Summary

Single-line fix adding pull_policy: build to the agents service sed replacement in --build mode. This is the same root cause as #887 applied to the single-instance compose path.

Verification

YAML indentation: The sed replaces image: ghcr.io/disinto/agents:.* (leaving the 4-space prefix intact), producing:

    build:
      context: .
      dockerfile: docker/agents/Dockerfile
    pull_policy: build

This matches the multi-agent template at lib/generators.sh:122-130 exactly — pull_policy: build at 4-space service-property indent alongside build:.

Fix placement: The pull_policy stanza lands in the same sed substitution that replaces image: with build:, so there's no window where build: exists without pull_policy: build.

Root cause match: Aligns with the documented lesson — build: present without pull_policy: build causes docker compose up to reuse a cached image rather than rebuild on source change.

Pre-existing Tech Debt Filed

#914 — edge service has the same missing pull_policy: build in --build mode (line 664); out of scope here but same root cause
#915 — No-op sed at line 662 (s|^\( agents:\)|\1|) replaces a string with itself; dead code from a prior iteration

Verdict

APPROVE — Correct fix: adds pull_policy: build to agents sed replacement, matching multi-agent template; YAML indentation is valid

Reviewed at 9f67f79 | AGENTS.md

## AI Review  ### Summary Single-line fix adding `pull_policy: build` to the `agents` service sed replacement in `--build` mode. This is the same root cause as #887 applied to the single-instance compose path. ### Verification **YAML indentation:** The sed replaces `image: ghcr.io/disinto/agents:.*` (leaving the 4-space prefix intact), producing: ```yaml build: context: . dockerfile: docker/agents/Dockerfile pull_policy: build ``` This matches the multi-agent template at `lib/generators.sh:122-130` exactly — `pull_policy: build` at 4-space service-property indent alongside `build:`. **Fix placement:** The `pull_policy` stanza lands in the same `sed` substitution that replaces `image:` with `build:`, so there's no window where `build:` exists without `pull_policy: build`. **Root cause match:** Aligns with the documented lesson — `build:` present without `pull_policy: build` causes `docker compose up` to reuse a cached image rather than rebuild on source change. ### Pre-existing Tech Debt Filed - **#914** — `edge` service has the same missing `pull_policy: build` in `--build` mode (line 664); out of scope here but same root cause - **#915** — No-op `sed` at line 662 (`s|^\( agents:\)|\1|`) replaces a string with itself; dead code from a prior iteration ### Verdict **APPROVE** — Correct fix: adds pull_policy: build to agents sed replacement, matching multi-agent template; YAML indentation is valid --- *Reviewed at `9f67f79` | [AGENTS.md](AGENTS.md)*

review-bot approved these changes 2026-04-16 20:07:14 +00:00

review-bot left a comment

Collaborator

AI Review: APPROVE — Correct fix: adds pull_policy: build to agents sed replacement, matching multi-agent template; YAML indentation is valid

AI Review: **APPROVE** — Correct fix: adds pull_policy: build to agents sed replacement, matching multi-agent template; YAML indentation is valid