fix: [nomad-step-4] S4-fix-2 — build disinto/agents:latest locally before deploy (no registry) (#972) #973

Merged

dev-qwen2 merged 1 commit from fix/issue-972 into main

2026-04-17 16:03:16 +00:00

dev-qwen2 commented

2026-04-17 15:48:06 +00:00

Collaborator

Fixes #972

Changes

Fixes #972 ## Changes

dev-qwen2 added 1 commit 2026-04-17 15:48:06 +00:00

fix: [nomad-step-4] S4-fix-2 — build disinto/agents:latest locally before deploy (no registry) (#972 )

ci/woodpecker/push/ci Pipeline was successful

Details

ci/woodpecker/push/nomad-validate Pipeline was successful

Details

ci/woodpecker/pr/ci Pipeline was successful

Details

ci/woodpecker/pr/nomad-validate Pipeline was successful

Details

ci/woodpecker/pr/smoke-init Pipeline was successful

Details

0c767d9fee

review-bot commented

2026-04-17 16:02:53 +00:00

Collaborator

AI Review

Review

The PR adds a docker build step for the agents service image before the Nomad deploy loop, for both dry-run display and real execution.

Correctness claims verified:

Ordering — build fires at lines 922–928, before the deploy loop at line 935. Correct.
Service detection — echo ",$with_services," | grep -q ",agents," wraps in commas to prevent partial matches (e.g., agents-extra). Matches the same pattern used in the deploy loop at line 941. Correct.
Dry-run fidelity — dry-run echo at line 830 matches the real command at line 927 (same flags, same paths). Correct.
Failure propagation — docker build ... 2>&1 | tail -5 under set -euo pipefail (line 24) propagates docker's nonzero exit; a failed build aborts the script. Correct.

Minor (non-blocking): Lines 924–926 emit two consecutive banner echoes before the build ("Building custom images" then "Building disinto/agents:latest"). Redundant but harmless.

Verdict

APPROVE — Build step correctly placed before deploy loop, service detection pattern matches existing convention, docker build failure propagates under pipefail

Reviewed at 0c767d9 | AGENTS.md

## AI Review  ### Review The PR adds a `docker build` step for the `agents` service image before the Nomad deploy loop, for both dry-run display and real execution. **Correctness claims verified:** 1. **Ordering** — build fires at lines 922–928, before the deploy loop at line 935. Correct. 2. **Service detection** — `echo ",$with_services," | grep -q ",agents,"` wraps in commas to prevent partial matches (e.g., `agents-extra`). Matches the same pattern used in the deploy loop at line 941. Correct. 3. **Dry-run fidelity** — dry-run echo at line 830 matches the real command at line 927 (same flags, same paths). Correct. 4. **Failure propagation** — `docker build ... 2>&1 | tail -5` under `set -euo pipefail` (line 24) propagates docker's nonzero exit; a failed build aborts the script. Correct. **Minor (non-blocking):** Lines 924–926 emit two consecutive banner echoes before the build ("Building custom images" then "Building disinto/agents:latest"). Redundant but harmless. ### Verdict **APPROVE** — Build step correctly placed before deploy loop, service detection pattern matches existing convention, docker build failure propagates under pipefail --- *Reviewed at `0c767d9` | [AGENTS.md](AGENTS.md)*

review-bot approved these changes 2026-04-17 16:02:53 +00:00

review-bot left a comment

Collaborator

AI Review: APPROVE — Build step correctly placed before deploy loop, service detection pattern matches existing convention, docker build failure propagates under pipefail

AI Review: **APPROVE** — Build step correctly placed before deploy loop, service detection pattern matches existing convention, docker build failure propagates under pipefail