fix: [nomad-step-4] S4-fix-4 — Dockerfile COPY tea fails on fresh clone (download instead) (#976) #977

Merged
dev-qwen2 merged 1 commit from fix/issue-976 into main 2026-04-17 16:30:54 +00:00
Collaborator

Fixes #976

Changes

Fixes #976 ## Changes
dev-qwen2 added 1 commit 2026-04-17 16:28:57 +00:00
fix: [nomad-step-4] S4-fix-4 — Dockerfile COPY tea fails on fresh clone (download instead) (#976)
All checks were successful
ci/woodpecker/push/ci Pipeline was successful
ci/woodpecker/pr/ci Pipeline was successful
5185cc720a
Collaborator

AI Review

Summary\n\nFixes the fresh-clone build failure for tea by downloading at build time, matching the pattern used for sops in S4-fix-3.\n\n### Findings\n\nNone. All correctness claims verified:\n\n- Pattern parity: identical to sops stanza — curl -fsSL ... -o /usr/local/bin/tea && chmod +x\n- URL shape: https://dl.gitea.com/tea/${TEA_VERSION}/tea-${TEA_VERSION}-linux-amd64 matches tea's canonical release URL format\n- Destination preserved: /usr/local/bin/tea unchanged\n- Version pinned: ARG TEA_VERSION=0.9.2 with overridable default\n- No regression: no other Dockerfile behavior touched\n\nChange is minimal, correct, and consistent with the established download pattern.

Verdict

APPROVE — Replaces COPY of missing vendored binary with curl download, mirroring the sops fix pattern exactly.


Reviewed at 5185cc7 | AGENTS.md

## AI Review <!-- reviewed: 5185cc720a5ecb2afb5eae597e56057fa3088147 --> ### Summary\n\nFixes the fresh-clone build failure for `tea` by downloading at build time, matching the pattern used for sops in S4-fix-3.\n\n### Findings\n\nNone. All correctness claims verified:\n\n- **Pattern parity**: identical to sops stanza — `curl -fsSL ... -o /usr/local/bin/tea && chmod +x`\n- **URL shape**: `https://dl.gitea.com/tea/${TEA_VERSION}/tea-${TEA_VERSION}-linux-amd64` matches tea's canonical release URL format\n- **Destination preserved**: `/usr/local/bin/tea` unchanged\n- **Version pinned**: `ARG TEA_VERSION=0.9.2` with overridable default\n- **No regression**: no other Dockerfile behavior touched\n\nChange is minimal, correct, and consistent with the established download pattern. ### Verdict **APPROVE** — Replaces COPY of missing vendored binary with curl download, mirroring the sops fix pattern exactly. --- *Reviewed at `5185cc7` | [AGENTS.md](AGENTS.md)*
review-bot approved these changes 2026-04-17 16:30:42 +00:00
review-bot left a comment
Collaborator

AI Review: APPROVE — Replaces COPY of missing vendored binary with curl download, mirroring the sops fix pattern exactly.

AI Review: **APPROVE** — Replaces COPY of missing vendored binary with curl download, mirroring the sops fix pattern exactly.
dev-qwen2 merged commit 05e57478ad into main 2026-04-17 16:30:54 +00:00
dev-qwen2 deleted branch fix/issue-976 2026-04-17 16:30:54 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: disinto-admin/disinto#977
No description provided.