fix: address review findings on formula templates and BOOTSTRAP docs
- upgrade-dependency.toml: fix forge upgrade command (forge update, not
forge install); remove redundant `npm install` after lockfile write;
simplify description to "Upgrade {{package}} to {{to_version}}" so it
reads cleanly when from_version is omitted
- add-rpc-method.toml: remove dead `namespace` variable; inline namespace
derivation logic into register-method step description
- BOOTSTRAP.md: mark formula label entry as requiring feat/formula merge;
add YAML front matter example so operators know the issue schema
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
parent
d16dc6175d
commit
88eed09e71
3 changed files with 8 additions and 12 deletions
|
|
@ -84,7 +84,7 @@ Optional but recommended:
|
||||||
|-------|---------|
|
|-------|---------|
|
||||||
| `tech-debt` | Gardener can promote these to `backlog` |
|
| `tech-debt` | Gardener can promote these to `backlog` |
|
||||||
| `blocked` | Dev-agent marks issues with unmet dependencies |
|
| `blocked` | Dev-agent marks issues with unmet dependencies |
|
||||||
| `formula` | Dev-agent uses a structured TOML formula instead of freeform — issue body must have YAML front matter specifying the formula name and variables (see `formulas/`) |
|
| `formula` | *(requires `feat/formula` merge)* Dev-agent uses a structured TOML formula instead of freeform. Issue body must include YAML front matter, e.g.:<br>`---`<br>`formula: upgrade-dependency`<br>`vars:`<br>` package: viem`<br>` ecosystem: npm`<br>`---` |
|
||||||
|
|
||||||
### Required: Branch protection
|
### Required: Branch protection
|
||||||
|
|
||||||
|
|
|
||||||
|
|
@ -18,11 +18,6 @@ description = "Return type description (e.g. 'U256 balance', 'Vec<Position>')"
|
||||||
required = false
|
required = false
|
||||||
default = "result"
|
default = "result"
|
||||||
|
|
||||||
[vars.namespace]
|
|
||||||
description = "RPC namespace prefix (e.g. eth, harb, net) — derived from method_name if omitted"
|
|
||||||
required = false
|
|
||||||
default = ""
|
|
||||||
|
|
||||||
[[steps]]
|
[[steps]]
|
||||||
id = "read-existing"
|
id = "read-existing"
|
||||||
title = "Read existing RPC methods for patterns"
|
title = "Read existing RPC methods for patterns"
|
||||||
|
|
@ -61,8 +56,9 @@ description = """
|
||||||
Add {{method_name}} to the server's method registry / router, following the
|
Add {{method_name}} to the server's method registry / router, following the
|
||||||
same registration pattern used by existing methods.
|
same registration pattern used by existing methods.
|
||||||
|
|
||||||
Verify the method is reachable — check that no namespace filter or
|
The namespace is the prefix of {{method_name}} before the underscore
|
||||||
allowlist would block it in the default configuration.
|
(e.g. "eth" for "eth_getBalance"). Verify the server's namespace filter or
|
||||||
|
allowlist includes this namespace in the default configuration.
|
||||||
"""
|
"""
|
||||||
needs = ["implement-handler"]
|
needs = ["implement-handler"]
|
||||||
|
|
||||||
|
|
|
||||||
|
|
@ -1,7 +1,7 @@
|
||||||
# formulas/upgrade-dependency.toml — Upgrade a package dependency
|
# formulas/upgrade-dependency.toml — Upgrade a package dependency
|
||||||
|
|
||||||
name = "upgrade-dependency"
|
name = "upgrade-dependency"
|
||||||
description = "Upgrade {{package}} from {{from_version}} to {{to_version}}"
|
description = "Upgrade {{package}} to {{to_version}}"
|
||||||
version = 1
|
version = 1
|
||||||
|
|
||||||
[vars.package]
|
[vars.package]
|
||||||
|
|
@ -38,11 +38,11 @@ description = """
|
||||||
Run the appropriate upgrade command for ecosystem={{ecosystem}}:
|
Run the appropriate upgrade command for ecosystem={{ecosystem}}:
|
||||||
|
|
||||||
- npm: npm install {{package}}@{{to_version}} (or @latest)
|
- npm: npm install {{package}}@{{to_version}} (or @latest)
|
||||||
Then: npm install (to sync lockfile)
|
|
||||||
- cargo: cargo update -p {{package}} [--precise {{to_version}}]
|
- cargo: cargo update -p {{package}} [--precise {{to_version}}]
|
||||||
Or bump version in Cargo.toml, then: cargo build
|
Or bump version in Cargo.toml, then: cargo build
|
||||||
- forge: Update version in foundry.toml or gitmodules, then:
|
- forge: forge update {{package}}
|
||||||
forge install {{package}} (or forge update {{package}})
|
(Use forge install only if reinstalling from scratch after manually
|
||||||
|
editing the commit hash in .gitmodules or lib/)
|
||||||
|
|
||||||
Confirm the lockfile / manifest now reflects {{to_version}}.
|
Confirm the lockfile / manifest now reflects {{to_version}}.
|
||||||
"""
|
"""
|
||||||
|
|
|
||||||
Loading…
Add table
Add a link
Reference in a new issue