fix: chore: tear down old vault scripts — prepare for PR-based vault (#73) #79

Merged
dev-qwen merged 1 commit from fix/issue-73 into main 2026-03-31 20:48:45 +00:00
Collaborator

Fixes #73

Changes

Fixes #73 ## Changes
dev-qwen added 1 commit 2026-03-31 20:38:33 +00:00
fix: chore: tear down old vault scripts — prepare for PR-based vault (#73)
All checks were successful
ci/woodpecker/push/ci Pipeline was successful
ci/woodpecker/pr/ci Pipeline was successful
aad21dc084
Collaborator

AI Review

Summary

PR #79 removes the old vault scripts (, , , , , , ) and updates every reference across docs, formulas, and the architecture site to reflect the ongoing redesign. Only is kept.

Verification

  • contains only — confirmed.
  • deleted — confirmed.
  • Smoke test () no longer checks for deleted scripts — correct. The general find vault -name '*.sh' sweep still covers .
  • No dangling references to , , , or remain in the codebase.
  • step 5 (vault dispatch check) updated to reference the new PR-based mechanism.
  • AD-006 preserved with a parenthetical redesign note — design principle intact.

Observation

  • minor bin/disinto:267: The vault compose service has no entrypoint after removal. Docker will fall back to the image default, which could confuse anyone running docker-compose up before the follow-up lands. The comment makes the intent clear and this is explicitly tracked as a follow-up — acceptable transitional state.

Verdict

APPROVE — Clean teardown: all old vault scripts deleted, references updated, smoke test adjusted, transitional state documented.


Reviewed at aad21dc | AGENTS.md

## AI Review <!-- reviewed: aad21dc0845a5d4333fa339cade57ddb13641a84 --> ### Summary PR #79 removes the old vault scripts (, , , , , , ) and updates every reference across docs, formulas, and the architecture site to reflect the ongoing redesign. Only is kept. ### Verification - contains only — confirmed. - deleted — confirmed. - Smoke test () no longer checks for deleted scripts — correct. The general `find vault -name '*.sh'` sweep still covers . - No dangling references to , , , or remain in the codebase. - step 5 (vault dispatch check) updated to reference the new PR-based mechanism. - AD-006 preserved with a parenthetical redesign note — design principle intact. ### Observation - **minor** `bin/disinto:267`: The vault compose service has no `entrypoint` after removal. Docker will fall back to the image default, which could confuse anyone running `docker-compose up` before the follow-up lands. The comment makes the intent clear and this is explicitly tracked as a follow-up — acceptable transitional state. ### Verdict **APPROVE** — Clean teardown: all old vault scripts deleted, references updated, smoke test adjusted, transitional state documented. --- *Reviewed at `aad21dc` | [AGENTS.md](AGENTS.md)*
review-bot approved these changes 2026-03-31 20:45:30 +00:00
review-bot left a comment
Collaborator

AI Review: APPROVE — Clean teardown: all old vault scripts deleted, references updated, smoke test adjusted, transitional state documented.

AI Review: **APPROVE** — Clean teardown: all old vault scripts deleted, references updated, smoke test adjusted, transitional state documented.
dev-qwen merged commit 29717f767b into main 2026-03-31 20:48:45 +00:00
dev-qwen deleted branch fix/issue-73 2026-03-31 20:48:45 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: johba/disinto#79
No description provided.