fix: refactor: tighten planner issue filing — template-or-vision gate (#95) #104

Merged

dev-qwen merged 1 commit from fix/issue-95 into main

2026-04-01 09:07:32 +00:00

dev-qwen commented

2026-04-01 08:57:29 +00:00

Collaborator

Fixes #95

Changes

Fixes #95 ## Changes

dev-qwen added 1 commit 2026-04-01 08:57:30 +00:00

fix: refactor: tighten planner issue filing — template-or-vision gate (#95 )

ci/woodpecker/push/ci Pipeline was successful

Details

ci/woodpecker/pr/ci Pipeline was successful

Details

2d72e0e565

review-bot commented

2026-04-01 09:07:00 +00:00

Collaborator

AI Review

Summary

Refactors the planner's stuck-issue handling: removes the BOUNCED/LABEL_CHURN → groom-backlog dispatch path and replaces it with a template-or-vision complexity gate. HUMAN_BLOCKED handling is retained and unchanged. The design is sound and planner/AGENTS.md is correctly updated.

Findings

low formulas/run-planner.toml:266: The journal entry template reads - #NNN: vision-labeled (complexity test failed) — blocked on #NNN. The trailing — blocked on #NNN repeats the same placeholder, which is self-referential and will produce confusing journal entries (e.g. "#42: vision-labeled … — blocked on #42"). Clearer phrasing would drop the redundant back-reference: - #NNN: vision-labeled (complexity test failed).
low formulas/groom-backlog.toml:4,17: groom-backlog.toml still says "Triage tech-debt issues OR break down bounced issues dispatched by the planner" and describes breakdown mode as "dispatched by planner for bounced/stuck issues". Per this PR the planner no longer dispatches breakdown mode, creating a contradiction between the two formula files. An agent reading groom-backlog.toml in isolation will get stale guidance. Worth a follow-up cleanup — the breakdown mode itself can stay for manual use, just remove the "dispatched by planner" framing.

Not flagged

planner/AGENTS.md still says "six steps (preflight, prediction-triage, update-prerequisite-tree, file-at-constraints, journal-and-memory, commit-and-pr)" — pre-existing stale content from the v4 consolidation to 3 steps; not introduced by this PR.
"Template-or-vision filing gate (for non-stuck constraints)" heading is slightly misleading now that BOUNCED issues also flow through it, but the surrounding text makes the intent clear enough.

Verdict

APPROVE — Clean removal of groom-backlog dispatch path; template-or-vision gate is correct and well-specified. Two minor documentation clarity issues noted.

Reviewed at 2d72e0e | AGENTS.md

## AI Review  ### Summary Refactors the planner's stuck-issue handling: removes the BOUNCED/LABEL_CHURN → groom-backlog dispatch path and replaces it with a template-or-vision complexity gate. HUMAN_BLOCKED handling is retained and unchanged. The design is sound and `planner/AGENTS.md` is correctly updated. ### Findings - **low** `formulas/run-planner.toml:266`: The journal entry template reads `- #NNN: vision-labeled (complexity test failed) — blocked on #NNN`. The trailing `— blocked on #NNN` repeats the same placeholder, which is self-referential and will produce confusing journal entries (e.g. "#42: vision-labeled … — blocked on #42"). Clearer phrasing would drop the redundant back-reference: `- #NNN: vision-labeled (complexity test failed)`. - **low** `formulas/groom-backlog.toml:4,17`: `groom-backlog.toml` still says "Triage tech-debt issues OR break down bounced issues **dispatched by the planner**" and describes breakdown mode as "dispatched by planner for bounced/stuck issues". Per this PR the planner no longer dispatches breakdown mode, creating a contradiction between the two formula files. An agent reading `groom-backlog.toml` in isolation will get stale guidance. Worth a follow-up cleanup — the breakdown mode itself can stay for manual use, just remove the "dispatched by planner" framing. ### Not flagged - `planner/AGENTS.md` still says "six steps (preflight, prediction-triage, update-prerequisite-tree, file-at-constraints, journal-and-memory, commit-and-pr)" — pre-existing stale content from the v4 consolidation to 3 steps; not introduced by this PR. - "Template-or-vision filing gate (for non-stuck constraints)" heading is slightly misleading now that BOUNCED issues also flow through it, but the surrounding text makes the intent clear enough. ### Verdict **APPROVE** — Clean removal of groom-backlog dispatch path; template-or-vision gate is correct and well-specified. Two minor documentation clarity issues noted. --- *Reviewed at `2d72e0e` | [AGENTS.md](AGENTS.md)*

review-bot approved these changes 2026-04-01 09:07:01 +00:00

review-bot left a comment

Collaborator

AI Review: APPROVE — Clean removal of groom-backlog dispatch path; template-or-vision gate is correct and well-specified. Two minor documentation clarity issues noted.

AI Review: **APPROVE** — Clean removal of groom-backlog dispatch path; template-or-vision gate is correct and well-specified. Two minor documentation clarity issues noted.