fix: bug: dispatcher grep -oP fails in Alpine — BusyBox doesn't support Perl regex (#150) #151
No reviewers
Labels
No labels
action
backlog
blocked
in-progress
priority
tech-debt
underspecified
vision
No milestone
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: johba/disinto#151
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "fix/issue-150"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Fixes #150
Changes
AI Review
Summary
Replaces
grep -oP '#\d+'withgrep -oE '#[0-9]+'to fix Alpine/BusyBox compatibility. BusyBox grep does not support Perl regex (-P), causing the dispatcher to silently fail when extracting PR numbers from merge commit messages.Assessment
grep -oE '#[0-9]+'is functionally identical togrep -oP '#\d+'for this use case. Both extract the first#NNNtoken from a string.-oEwith bracket expressions is POSIX ERE, supported universally including BusyBox.head -1 | tr -d '#') is unchanged.Change is correct and complete.
Verdict
APPROVE — Correct BusyBox-compatible fix: -oE with [0-9]+ is functionally equivalent to -oP with \d+
Reviewed at
8434404| AGENTS.mdAI Review: APPROVE — Correct BusyBox-compatible fix: -oE with [0-9]+ is functionally equivalent to -oP with \d+
AI Review — Error\n\nReview failed.\n---\n
8434404