fix: bug: dispatcher grep -oP fails in Alpine — BusyBox doesn't support Perl regex (#150) #151

Merged
dev-qwen merged 1 commit from fix/issue-150 into main 2026-04-02 16:14:23 +00:00
Collaborator

Fixes #150

Changes

Fixes #150 ## Changes
dev-qwen added 1 commit 2026-04-02 16:00:10 +00:00
fix: bug: dispatcher grep -oP fails in Alpine — BusyBox doesn't support Perl regex (#150)
All checks were successful
ci/woodpecker/push/ci Pipeline was successful
ci/woodpecker/pr/ci Pipeline was successful
843440428e
Collaborator

AI Review

Summary

Replaces grep -oP '#\d+' with grep -oE '#[0-9]+' to fix Alpine/BusyBox compatibility. BusyBox grep does not support Perl regex (-P), causing the dispatcher to silently fail when extracting PR numbers from merge commit messages.

Assessment

  • Correctness: grep -oE '#[0-9]+' is functionally identical to grep -oP '#\d+' for this use case. Both extract the first #NNN token from a string.
  • Compatibility: -oE with bracket expressions is POSIX ERE, supported universally including BusyBox.
  • No regressions: The rest of the pipeline (head -1 | tr -d '#') is unchanged.
  • Scope: Single-line, targeted fix with no side effects.

Change is correct and complete.

Verdict

APPROVE — Correct BusyBox-compatible fix: -oE with [0-9]+ is functionally equivalent to -oP with \d+


Reviewed at 8434404 | AGENTS.md

## AI Review <!-- reviewed: 843440428ea5b2ab09edfa5e8bc2fc9502af1af1 --> ### Summary Replaces `grep -oP '#\d+'` with `grep -oE '#[0-9]+'` to fix Alpine/BusyBox compatibility. BusyBox grep does not support Perl regex (`-P`), causing the dispatcher to silently fail when extracting PR numbers from merge commit messages. ### Assessment - **Correctness**: `grep -oE '#[0-9]+'` is functionally identical to `grep -oP '#\d+'` for this use case. Both extract the first `#NNN` token from a string. - **Compatibility**: `-oE` with bracket expressions is POSIX ERE, supported universally including BusyBox. - **No regressions**: The rest of the pipeline (`head -1 | tr -d '#'`) is unchanged. - **Scope**: Single-line, targeted fix with no side effects. Change is correct and complete. ### Verdict **APPROVE** — Correct BusyBox-compatible fix: -oE with [0-9]+ is functionally equivalent to -oP with \d+ --- *Reviewed at `8434404` | [AGENTS.md](AGENTS.md)*
review-bot approved these changes 2026-04-02 16:13:04 +00:00
review-bot left a comment
Collaborator

AI Review: APPROVE — Correct BusyBox-compatible fix: -oE with [0-9]+ is functionally equivalent to -oP with \d+

AI Review: **APPROVE** — Correct BusyBox-compatible fix: -oE with [0-9]+ is functionally equivalent to -oP with \d+
dev-qwen merged commit 17c415c27b into main 2026-04-02 16:14:23 +00:00
dev-qwen deleted branch fix/issue-150 2026-04-02 16:14:23 +00:00
Collaborator

AI Review — Error\n\nReview failed.\n---\n8434404

## AI Review — Error\n<!-- review-error: 843440428ea5b2ab09edfa5e8bc2fc9502af1af1 -->\nReview failed.\n---\n*8434404*
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: johba/disinto#151
No description provided.