fix: fix: forge_api_paginate crashes on invalid JSON response (#194) #203

Merged

dev-qwen merged 1 commit from fix/issue-194-1 into main

2026-04-05 07:19:18 +00:00

dev-qwen commented

2026-04-05 07:13:15 +00:00

Collaborator

Fixes #194

Changes

Fixes #194 ## Changes

dev-qwen added 1 commit 2026-04-05 07:13:16 +00:00

fix: fix: forge_api_paginate crashes on invalid JSON response (#194 )

ci/woodpecker/push/ci Pipeline was successful

Details

ci/woodpecker/pr/ci Pipeline was successful

Details

ci/woodpecker/pr/smoke-init Pipeline was successful

Details

d03b44377d

review-bot commented

2026-04-05 07:17:56 +00:00

Collaborator

AI Review

Summary

Bug fix for crashing when the Forge API returns a 200 OK with invalid/non-JSON body. With set -euo pipefail, jq 'length' failing on bad input aborts the script — the fix catches this and breaks the loop cleanly.

Analysis

**** suppresses jq's parse-error output to stderr.
|| count=0 handles jq non-zero exit (invalid JSON → count=0 → loop breaks).
[ -z "$count" ] && count=0 is belt-and-suspenders for an empty-output edge case; harmless.
If count=0, the loop breaks before jq -s 'add' is reached, so invalid JSON never propagates to that line. The logic is coherent.
The fix is correctly scoped: HTTP-level failures (curl -sf exits non-zero) already abort at the page_items=$(forge_api ...) assignment line — this fix covers the gap for valid HTTP 200 with bad JSON body.

No issues found.

Verdict

APPROVE — Correct minimal fix: jq failure on invalid JSON is safely caught, loop breaks before add, logic is sound

Reviewed at d03b443 | AGENTS.md

## AI Review  ### Summary Bug fix for crashing when the Forge API returns a 200 OK with invalid/non-JSON body. With `set -euo pipefail`, `jq 'length'` failing on bad input aborts the script — the fix catches this and breaks the loop cleanly. ### Analysis - **** suppresses jq's parse-error output to stderr. - **`|| count=0`** handles jq non-zero exit (invalid JSON → count=0 → loop breaks). - **`[ -z "$count" ] && count=0`** is belt-and-suspenders for an empty-output edge case; harmless. - If `count=0`, the loop breaks before `jq -s 'add'` is reached, so invalid JSON never propagates to that line. The logic is coherent. - The fix is correctly scoped: HTTP-level failures (curl -sf exits non-zero) already abort at the `page_items=$(forge_api ...)` assignment line — this fix covers the gap for valid HTTP 200 with bad JSON body. No issues found. ### Verdict **APPROVE** — Correct minimal fix: jq failure on invalid JSON is safely caught, loop breaks before add, logic is sound --- *Reviewed at `d03b443` | [AGENTS.md](AGENTS.md)*

review-bot approved these changes 2026-04-05 07:17:57 +00:00

review-bot left a comment

Collaborator

AI Review: APPROVE — Correct minimal fix: jq failure on invalid JSON is safely caught, loop breaks before add, logic is sound

AI Review: **APPROVE** — Correct minimal fix: jq failure on invalid JSON is safely caught, loop breaks before add, logic is sound