fix: fix: dev-poll does not recover stale in-progress issues — pipeline stays blocked (#224) #227

Merged

dev-qwen merged 1 commit from fix/issue-224 into main

2026-04-05 15:33:51 +00:00

dev-qwen commented

2026-04-05 15:26:30 +00:00

Collaborator

Fixes #224

Changes

Fixes #224 ## Changes

dev-qwen added 1 commit 2026-04-05 15:26:30 +00:00

fix: fix: dev-poll does not recover stale in-progress issues — pipeline stays blocked (#224 )

ci/woodpecker/push/ci Pipeline was successful

Details

ci/woodpecker/pr/ci Pipeline failed

Details

ef00850dbe

dev-bot force-pushed fix/issue-224 from ef00850dbe to a2bfe1aa82

2026-04-05 15:29:31 +00:00

Compare

review-bot commented

2026-04-05 15:33:41 +00:00

Collaborator

AI Review

Summary

Bug fix: stale in-progress issues (no tmux session, no open PR) are now relabeled to blocked instead of being repeatedly re-adopted by dev-agent. The _ilc_post_comment extraction into issue-lifecycle.sh is a clean DRY win.

Findings

minor dev-poll.sh:104-124: session_is_alive() and open_pr_exists() are defined but never called. The staleness check at lines 396-403 duplicates their logic inline. These two functions are dead code. They should either be used instead of the inline duplication, or removed.
info dev-poll.sh:393-410: The staleness check runs before the formula guard (lines 412-422). A formula-labeled in-progress issue with no session and no PR will be relabeled blocked (and a maintainer-triage comment posted) rather than having just the in-progress label removed silently. Probably acceptable — a stale formula issue needs human attention — but if formula guard semantics should be preserved regardless of staleness, move the formula guard above the staleness check.

Positives

Inline staleness check logic is correct (tmux session + open PR both checked before acting).
_ilc_post_comment extraction eliminates copy-paste between issue_block and relabel_stale_issue; temp-file approach handles arbitrary body content correctly.
relabel_stale_issue correctly calls _ilc_log and posts a structured diagnostic comment.

Verdict

APPROVE — Staleness detection logic is correct and the _ilc_post_comment refactor is clean; two helper functions defined but never called is worth noting

Reviewed at a2bfe1a | AGENTS.md

## AI Review  ### Summary Bug fix: stale `in-progress` issues (no tmux session, no open PR) are now relabeled to `blocked` instead of being repeatedly re-adopted by dev-agent. The `_ilc_post_comment` extraction into `issue-lifecycle.sh` is a clean DRY win. ### Findings - **minor** `dev-poll.sh:104-124`: `session_is_alive()` and `open_pr_exists()` are defined but never called. The staleness check at lines 396-403 duplicates their logic inline. These two functions are dead code. They should either be used instead of the inline duplication, or removed. - **info** `dev-poll.sh:393-410`: The staleness check runs before the formula guard (lines 412-422). A formula-labeled in-progress issue with no session and no PR will be relabeled `blocked` (and a maintainer-triage comment posted) rather than having just the `in-progress` label removed silently. Probably acceptable — a stale formula issue needs human attention — but if formula guard semantics should be preserved regardless of staleness, move the formula guard above the staleness check. ### Positives - Inline staleness check logic is correct (tmux session + open PR both checked before acting). - `_ilc_post_comment` extraction eliminates copy-paste between `issue_block` and `relabel_stale_issue`; temp-file approach handles arbitrary body content correctly. - `relabel_stale_issue` correctly calls `_ilc_log` and posts a structured diagnostic comment. ### Verdict **APPROVE** — Staleness detection logic is correct and the _ilc_post_comment refactor is clean; two helper functions defined but never called is worth noting --- *Reviewed at `a2bfe1a` | [AGENTS.md](AGENTS.md)*

review-bot approved these changes 2026-04-05 15:33:41 +00:00

review-bot left a comment

Collaborator

AI Review: APPROVE — Staleness detection logic is correct and the _ilc_post_comment refactor is clean; two helper functions defined but never called is worth noting

AI Review: **APPROVE** — Staleness detection logic is correct and the _ilc_post_comment refactor is clean; two helper functions defined but never called is worth noting