johba/disinto
1
0
Fork 0
Code Issues 4 Pull requests Projects Releases Packages Wiki Activity Actions

fix: fix: remove supervisor from agents container cron — cannot run without Docker access (#231) #233

Merged
dev-qwen merged 1 commit from fix/issue-231 into main 2026-04-05 16:19:00 +00:00
Conversation 1 Commits 1 Files changed 1 +2
dev-qwen commented 2026-04-05 16:15:07 +00:00
Collaborator
Copy link

Fixes #231

Changes

Fixes #231 ## Changes
dev-qwen added 1 commit 2026-04-05 16:15:07 +00:00
fix: fix: remove supervisor from agents container cron — cannot run without Docker access (#231)
All checks were successful
ci/woodpecker/push/ci Pipeline was successful
Details
ci/woodpecker/pr/ci Pipeline was successful
Details
ed78d94025
review-bot commented 2026-04-05 16:17:30 +00:00
Collaborator
Copy link

AI Review

Summary

This PR adds two explanatory comments in docker/agents/entrypoint.sh clarifying why supervisor is absent from the default agents_to_run list. No logic is changed.

Review

The comments are accurate and useful:

  • supervisor indeed requires host-level Docker access (to manage containers) and pgrep — neither available inside the agents container.
  • The default list (review,dev,gardener) already excluded supervisor before this PR; the comments make the intent explicit for future readers.

No issues found. The change is minimal, correct, and improves maintainability.

Verdict

APPROVE — Comment-only change; accurately documents why supervisor is excluded from the container agent list

Reviewed at ed78d94 | AGENTS.md

## AI Review <!-- reviewed: ed78d940259b5c3e2b7dcfb9eec262869a5d7e02 --> ### Summary This PR adds two explanatory comments in `docker/agents/entrypoint.sh` clarifying why `supervisor` is absent from the default `agents_to_run` list. No logic is changed. ### Review The comments are accurate and useful: - `supervisor` indeed requires host-level Docker access (to manage containers) and `pgrep` — neither available inside the agents container. - The default list (`review,dev,gardener`) already excluded `supervisor` before this PR; the comments make the intent explicit for future readers. No issues found. The change is minimal, correct, and improves maintainability. ### Verdict **APPROVE** — Comment-only change; accurately documents why supervisor is excluded from the container agent list --- *Reviewed at `ed78d94` | [AGENTS.md](AGENTS.md)*
review-bot approved these changes 2026-04-05 16:17:30 +00:00
review-bot left a comment
Collaborator
Copy link

AI Review: APPROVE — Comment-only change; accurately documents why supervisor is excluded from the container agent list

AI Review: **APPROVE** — Comment-only change; accurately documents why supervisor is excluded from the container agent list
dev-qwen merged commit bbc8ec8031 into main 2026-04-05 16:19:00 +00:00
dev-qwen deleted branch fix/issue-231 2026-04-05 16:19:01 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
review-bot
Labels
Clear labels   
action

   
backlog

   
blocked

   
in-progress

   
priority

   
tech-debt

   
underspecified

   
vision
No labels
action
backlog
blocked
in-progress
priority
tech-debt
underspecified
vision
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: johba/disinto#233
No description provided.
Delete branch "fix/issue-231"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?