johba/disinto
1
0
Fork 0
Code Issues 5 Pull requests Projects Releases Packages Wiki Activity Actions

fix: fix: DELETE /issues/{n}/labels/{id} uses label name instead of numeric ID (silent no-op) (#41) #46

Merged
dev-bot merged 1 commit from fix/issue-41 into main 2026-03-28 21:50:12 +00:00
Conversation 2 Commits 1 Files changed 1 +6 -3
dev-bot commented 2026-03-28 21:45:20 +00:00
Collaborator
Copy link

Fixes #41

Changes

Fixes #41 ## Changes
dev-bot added 1 commit 2026-03-28 21:45:21 +00:00
fix: fix: DELETE /issues/{n}/labels/{id} uses label name instead of numeric ID (silent no-op) (#41)
All checks were successful
ci/woodpecker/push/ci Pipeline was successful
Details
ci/woodpecker/pr/ci Pipeline was successful
Details
ci/woodpecker/push/smoke-init removed
ci/woodpecker/pr/smoke-init removed
76a4d42a42
review-bot commented 2026-03-28 21:48:45 +00:00
Collaborator
Copy link

AI Review

Summary

The bug: Forgejo's DELETE /issues/{n}/labels/{id} endpoint requires a numeric label ID, not a label name string. Passing "in-progress" was a silent no-op.

The fix: calls _ilc_in_progress_id() — the same helper already used throughout lib/issue-lifecycle.sh (lines 114, 147, 201) — to resolve the numeric ID before each of the three DELETE curl calls in dev-poll.sh.

All three changed call sites are correct. No edge cases missed.

Verdict

APPROVE — Correctly replaces hardcoded label name string with numeric ID lookup, matching the established pattern in issue-lifecycle.sh

Reviewed at 76a4d42 | AGENTS.md

## AI Review <!-- reviewed: 76a4d42a4254be569eeaf3bb0d48b4d06b154057 --> ### Summary The bug: Forgejo's `DELETE /issues/{n}/labels/{id}` endpoint requires a numeric label ID, not a label name string. Passing `"in-progress"` was a silent no-op. The fix: calls `_ilc_in_progress_id()` — the same helper already used throughout `lib/issue-lifecycle.sh` (lines 114, 147, 201) — to resolve the numeric ID before each of the three DELETE curl calls in `dev-poll.sh`. All three changed call sites are correct. No edge cases missed. ### Verdict **APPROVE** — Correctly replaces hardcoded label name string with numeric ID lookup, matching the established pattern in issue-lifecycle.sh --- *Reviewed at `76a4d42` | [AGENTS.md](AGENTS.md)*
review-bot approved these changes 2026-03-28 21:48:46 +00:00
review-bot left a comment
Collaborator
Copy link

AI Review: APPROVE — Correctly replaces hardcoded label name string with numeric ID lookup, matching the established pattern in issue-lifecycle.sh

AI Review: **APPROVE** — Correctly replaces hardcoded label name string with numeric ID lookup, matching the established pattern in issue-lifecycle.sh
dev-bot merged commit 06da075505 into main 2026-03-28 21:50:12 +00:00
dev-bot deleted branch fix/issue-41 2026-03-28 21:50:13 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
review-bot
Labels
Clear labels   
action

   
backlog

   
blocked

   
in-progress

   
priority

   
tech-debt

   
underspecified

   
vision
No labels
action
backlog
blocked
in-progress
priority
tech-debt
underspecified
vision
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: johba/disinto#46
No description provided.
Delete branch "fix/issue-41"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?