fix: fix: dev-poll.sh in-progress scan falls through on waiting PRs (#55) #57

Merged

dev-qwen merged 1 commit from fix/issue-55 into main

2026-03-29 11:42:41 +00:00

dev-qwen commented

2026-03-29 11:32:20 +00:00

Collaborator

Fixes #55

Changes

Fixes #55 ## Changes

dev-qwen added 1 commit 2026-03-29 11:32:21 +00:00

fix: fix: dev-poll.sh in-progress scan falls through on waiting PRs (#55 )

ci/woodpecker/push/ci Pipeline was successful

Details

ci/woodpecker/pr/ci Pipeline was successful

Details

b49309141b

review-bot commented

2026-03-29 11:38:28 +00:00

Collaborator

AI Review

Summary\n\nThis PR fixes a fall-through bug in the in-progress issue scan (Priority 1). When an issue had an open PR in "waiting" state (CI pending/passing, no approval, no REQUEST_CHANGES), the `else` branch logged a message but did not exit — causing execution to continue into the Priority 1.5 stuck-PR scan. That could trigger unnecessary agent spawns for PRs that simply haven't been reviewed yet.\n\nAll other branches in this same `if/elif/else` block already called `exit 0`. The missing exit was an oversight.\n\n### Checklist\n\n- Logic: Fix is correct. The `else` branch is reached only when: has open PR, CI not passed+approved, no REQUEST_CHANGES, CI not failed — i.e., genuinely waiting. Exiting is the right behavior.\n- Pattern consistency: Every other terminal branch in this block exits. The fix aligns with that pattern.\n- Bash/ShellCheck: Single-line addition, no quoting or safety concerns.\n- Scope: No unrelated changes.\n\nChange is correct and complete.

Verdict

APPROVE — Correct minimal fix: adds missing exit 0 to prevent fall-through from waiting-PR branch into Priority 1.5 stuck-PR scan

Reviewed at b493091 | AGENTS.md

## AI Review  ### Summary\n\nThis PR fixes a fall-through bug in the in-progress issue scan (Priority 1). When an issue had an open PR in "waiting" state (CI pending/passing, no approval, no REQUEST_CHANGES), the `else` branch logged a message but did not exit — causing execution to continue into the Priority 1.5 stuck-PR scan. That could trigger unnecessary agent spawns for PRs that simply haven't been reviewed yet.\n\nAll other branches in this same `if/elif/else` block already called `exit 0`. The missing exit was an oversight.\n\n### Checklist\n\n- **Logic**: Fix is correct. The `else` branch is reached only when: has open PR, CI not passed+approved, no REQUEST_CHANGES, CI not failed — i.e., genuinely waiting. Exiting is the right behavior.\n- **Pattern consistency**: Every other terminal branch in this block exits. The fix aligns with that pattern.\n- **Bash/ShellCheck**: Single-line addition, no quoting or safety concerns.\n- **Scope**: No unrelated changes.\n\nChange is correct and complete. ### Verdict **APPROVE** — Correct minimal fix: adds missing exit 0 to prevent fall-through from waiting-PR branch into Priority 1.5 stuck-PR scan --- *Reviewed at `b493091` | [AGENTS.md](AGENTS.md)*

review-bot approved these changes 2026-03-29 11:38:28 +00:00

review-bot left a comment

Collaborator

AI Review: APPROVE — Correct minimal fix: adds missing exit 0 to prevent fall-through from waiting-PR branch into Priority 1.5 stuck-PR scan

AI Review: **APPROVE** — Correct minimal fix: adds missing exit 0 to prevent fall-through from waiting-PR branch into Priority 1.5 stuck-PR scan